You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/11/28 03:52:01 UTC
[PR] GH-38907: [C++] Stop installing internal bpacking_simd* headers [arrow]
kou opened a new pull request, #38908:
URL: https://github.com/apache/arrow/pull/38908
### Rationale for this change
They are for internal use. We don't need to install them.
### What changes are included in this PR?
Use `_internal.h` suffix to avoid installing them.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38907: [C++] Stop installing internal bpacking_simd* headers [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38908:
URL: https://github.com/apache/arrow/pull/38908#issuecomment-1830363253
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38907: [C++] Stop installing internal bpacking_simd* headers [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38908:
URL: https://github.com/apache/arrow/pull/38908#issuecomment-1833638671
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9aff60a70b3d526a9c7d7769935140cf7830e5b6.
There was 1 benchmark result with an error:
- Commit Run on `ursa-i9-9960x` at [2023-11-30 09:48:55Z](https://conbench.ursa.dev/compare/runs/b156d4739f9d45de98937f731bd4b574...53ee5493b1d741bfb74ab6270f94a19f/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-13, scale_factor=10](https://conbench.ursa.dev/benchmark-results/0656871143117ac9800001ef44224a96)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/19177485145) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38907: [C++] Stop installing internal bpacking_simd* headers [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #38908:
URL: https://github.com/apache/arrow/pull/38908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38907: [C++] Stop installing internal bpacking_simd* headers [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38908:
URL: https://github.com/apache/arrow/pull/38908#issuecomment-1829028979
:warning: GitHub issue #38907 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38907: [C++] Stop installing internal bpacking_simd* headers [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38908:
URL: https://github.com/apache/arrow/pull/38908#issuecomment-1830366814
Revision: 70491af87d879f65695c31f096a57c31cfa5c2b1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bc72a8712b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bc72a8712b)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7022433926/job/19106689559)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/7022431065/job/19106680767)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7022432925/job/19106686137)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/19106689613)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7022432273/job/19106684209)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7022429862/job/19106676790)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/7022430519/job/19106678883)|
|test-fedora-38-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7022429497/job/19106675631)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7022430826/job/19106680010)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/7022429245/job/19106674889)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/7022433928/job/19106689610)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/7022431415/job/19106681960)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7022429348/job/19106675045)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/7022430249/job/19106678036)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/7022432607/job/19106685294)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org