You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/29 17:40:08 UTC

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation

comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation
URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372526415
 
 

 ##########
 File path: python/tvm/relay/op/nn/nn.py
 ##########
 @@ -202,6 +203,8 @@ def conv2d(data,
         dilation = (dilation, dilation)
     if isinstance(padding, int):
         padding = (padding, padding)
 
 Review comment:
   Consider removing this logic since `get_pad_tuple` can also accept `int`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services