You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/08/20 05:57:11 UTC

[Bug 5962] New: new Message-ID pattern from OE Hotmail users cause FPs

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962

           Summary: new Message-ID pattern from OE Hotmail users cause FPs
           Product: Spamassassin
           Version: 3.2.5
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Rules
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: rogers@outblaze.com


The __OE_MSGID_3 test is not matching Outlook Express Message-IDs that begin
with "BLU" instead of "BAY".

Relevant headers:

Received: from bay0-omc3-s31.bay0.hotmail.com (bay0-omc3-s31.bay0.hotmail.com
[65.54.246.231])
        by corpmail.outblaze.com (Postfix) with ESMTP
        id 8F81B16DD84; Mon, 18 Aug 2008 08:04:42 +0000 (GMT)
Received: from hotmail.com ([10.6.61.21]) by bay0-omc3-s31.bay0.hotmail.com
with Microsoft SMTPSVC(6.0.3790.3959);
        Mon, 18 Aug 2008 01:04:41 -0700
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
        Mon, 18 Aug 2008 01:04:40 -0700
Message-ID: <BL...@phx.gbl>
Received: from 76.254.79.201 by BLU110-DAV11.phx.gbl with DAV;
        Mon, 18 Aug 2008 08:04:35 +0000

X-Mailer: Microsoft Outlook Express 6.00.2900.3138
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962





--- Comment #5 from Justin Mason <jm...@jmason.org>  2008-08-20 04:35:52 PST ---
thanks for noting that; I've moved them all to the same milestone and marked
them as interdependent.


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |5946




-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paulg@cse.yorku.ca




--- Comment #7 from Justin Mason <jm...@jmason.org>  2008-12-29 04:46:08 PST ---
*** Bug 5946 has been marked as a duplicate of this bug. ***


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.2.6




--- Comment #3 from Justin Mason <jm...@jmason.org>  2008-08-20 01:57:21 PST ---
thanks guys, will apply this rsn


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |5874




-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962





--- Comment #1 from Yusuf Goolamabbas <yu...@outblaze.com>  2008-08-19 21:27:39 PST ---
Created an attachment (id=4356)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4356)
patch against trunk

Proposed patch, thanks to roger. Am submitting it on his behalf because I have
CLA on file. He'll be sending his shortly

Patch is against trunk


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #6 from Justin Mason <jm...@jmason.org>  2008-12-29 04:45:57 PST ---
ok, fixed in trunk:

: 197...; svn commit -m "bug 5496, bug 5962: fix FORGED_MUA_OUTLOOK false
positives, using rule suggestion derived from Roger So and Yusuf Goolamabbas.
also add test cases"
Sending        rules/20_ratware.cf
Adding         t.rules/FORGED_MUA_OUTLOOK/fp-5946-1
Adding         t.rules/FORGED_MUA_OUTLOOK/fp-5962-1
Transmitting file data ...
Committed revision 729888 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=729888 ).

I've simply made the pattern more generic:


-header __HOTMAIL_BAYDAV_MSGID          MESSAGEID =~
/^<BAY\d+-DAV\d+[A-Z0-9]{25}\@phx\.gbl>$/m
+header __HOTMAIL_BAYDAV_MSGID          MESSAGEID =~
/^<[A-Z]{3}\d+-(?:DAV|SMTP)\d+[A-Z0-9]{25}\@phx\.gbl>$/m


in other words, accept any 3-letter prefix and allow SMTP as well as DAV in the
middle.  we have too many fps on these rules to be more specific than that,
IMO.

next step is to backport to 3.2.x and issue updates.


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #8 from Justin Mason <jm...@jmason.org>  2008-12-29 07:12:27 PST ---
in 3.2.x:

: 30...; svn commit -m "bug 5496, bug 5962: fix FORGED_MUA_OUTLOOK false
positives, using rule suggestion derived from Roger So and Yusuf Goolamabbas"
rules/20_ratware.cf 
Sending        rules/20_ratware.cf
Transmitting file data .
Committed revision 729908 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=729908 ).

and -- with some messy integration :( -- to 3.2.x updates:

: 43...; svn commit -m "bug 5496, bug 5962: fix FORGED_MUA_OUTLOOK false
positives, using rule suggestion derived from Roger So and Yusuf Goolamabbas"
../b3_2_0_updates/20_ratware.cf 
Sending        b3_2_0_updates/20_ratware.cf
Transmitting file data .
Committed revision 729909 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=729909 ).

rule update pushed:

: exit=1 Mon Dec 29 15:11:57 GMT 2008; cd
/export/home/jm/ftp/spamassassin/build/mkupdat
: jm 147...; sudo -u updatesd ./update-rules 3.2

Committed revision 729912 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=729912 ).
gpg: WARNING: using insecure memory!
gpg: please see http://www.gnupg.org/faq.html for more information
commands will be executed using /bin/bash
job 1230564427.n at Mon Dec 29 15:27:07 2008
DNS zone reload scheduled


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Yusuf Goolamabbas <yu...@outblaze.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4356 is|0                           |1
           obsolete|                            |




--- Comment #2 from Yusuf Goolamabbas <yu...@outblaze.com>  2008-08-19 21:52:59 PST ---
Created an attachment (id=4357)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4357)
updated patch

Picked up the wrong patch by mistake


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962





--- Comment #4 from Karsten Bräckelmann <gu...@rudersport.de>  2008-08-20 04:18:20 PST ---
Also see bug 5874 (FP) and bug 5946 (FP, patch) for similar issues. Dupes?

They all suffer from BLU prefixed Message-Id's, though with different strings
after the hyphen. In particular, neither will fix the FP in bug 5874. Possibly
even more such bugs.

FWIW, this seems to be the only patch against trunk, where __OE_MSGID_3
apparently has been renamed to __HOTMAIL_BAYDAV_MSGID.


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5962] new Message-ID pattern from OE Hotmail users cause FPs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5962


Yusuf Goolamabbas <yu...@outblaze.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yusufg@outblaze.com




-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.