You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/03/15 23:47:55 UTC

Review Request: Factored out realpath, used to construct path for 'mesos-executor'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4372/
-----------------------------------------------------------

Review request for mesos and John Sirois.


Summary
-------

See summary.


Diffs
-----

  src/common/utils.hpp 467f12b 
  src/slave/slave.hpp bf01aef 
  src/tests/main.cpp c42264f 

Diff: https://reviews.apache.org/r/4372/diff


Testing
-------

make check


Thanks,

Benjamin


Re: Review Request: Factored out realpath, used to construct path for 'mesos-executor'.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On 2012-03-15 23:00:22, John Sirois wrote:
> >

Thanks John, submitting.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4372/#review6009
-----------------------------------------------------------


On 2012-03-15 22:47:55, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4372/
> -----------------------------------------------------------
> 
> (Updated 2012-03-15 22:47:55)
> 
> 
> Review request for mesos and John Sirois.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/utils.hpp 467f12b 
>   src/slave/slave.hpp bf01aef 
>   src/tests/main.cpp c42264f 
> 
> Diff: https://reviews.apache.org/r/4372/diff
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Re: Review Request: Factored out realpath, used to construct path for 'mesos-executor'.

Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4372/#review6009
-----------------------------------------------------------

Ship it!


- John


On 2012-03-15 22:47:55, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4372/
> -----------------------------------------------------------
> 
> (Updated 2012-03-15 22:47:55)
> 
> 
> Review request for mesos and John Sirois.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/utils.hpp 467f12b 
>   src/slave/slave.hpp bf01aef 
>   src/tests/main.cpp c42264f 
> 
> Diff: https://reviews.apache.org/r/4372/diff
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin
> 
>