You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Karan Mehta (JIRA)" <ji...@apache.org> on 2018/06/14 05:53:00 UTC

[jira] [Created] (PHOENIX-4781) Phoenix client project's jar naming convention causes maven-deploy-plugin to fail

Karan Mehta created PHOENIX-4781:
------------------------------------

             Summary: Phoenix client project's jar naming convention causes maven-deploy-plugin to fail
                 Key: PHOENIX-4781
                 URL: https://issues.apache.org/jira/browse/PHOENIX-4781
             Project: Phoenix
          Issue Type: Improvement
            Reporter: Karan Mehta


`maven-deploy-plugin` is used for deploying built artifacts to repository provided by `distributionManagement` tag. The name of files that need to be uploaded are either derived from pom file of the project or it generates an temporary one on its own.

For `phoenix-client` project, we essentially create a shaded uber jar that contains all dependencies and provide the project pom file for the plugin to work. `maven-jar-plugin` is disabled for the project, hence the shade plugin essentially packages the jar. The final name of the shaded jar is defined as `phoenix-${project.version}-client`, which is different from how the standard maven convention based on pom file (artifact and group id) is `phoenix-client-${project.version}`

This causes `maven-deploy-plugin` to fail since it is unable to find any artifacts to be published.

`maven-install-plugin` works correctly and hence it installs correct jar in local repo.

The same is effective for `phoenix-pig` project as well. However we require the require jar for that project in the repo. I am not even sure why we create shaded jar for that project.

I will put up a 3 liner patch for the same.

Any thoughts? [~sergey.soldatov] [~elserj]

Files before change (first col is size):
{code:java}
103487701 Jun 13 22:47 phoenix-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT-client.jar{code}
Files after change (first col is size):
{code:java}
3640 Jun 13 21:23 original-phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar
103487702 Jun 13 21:24 phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)