You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/16 15:57:32 UTC
[GitHub] [camel-k] squakez opened a new pull request #3123: fix(ci): remove unused maven references
squakez opened a new pull request #3123:
URL: https://github.com/apache/camel-k/pull/3123
Tentatively PR to see if there are no hidden usage of `.mvnw` discovered by the CI.
- [x] Remove `.mvnw` references
- [ ] Change the way we `make images-dev` to remove the pom.xml dependency
- [ ] Check if we can rework the `make maven-overlay`
Ref #2659
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(ci): remove unused maven references
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a change in pull request #3123: fix(ci): remove unused maven references
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #3123:
URL: https://github.com/apache/camel-k/pull/3123#discussion_r828279831
##########
File path: script/get_catalog.sh
##########
@@ -21,14 +21,12 @@ rootdir=$location/../
if [ "$#" -ge 1 ]; then
runtimeVersion="$1"
shift 1
- $rootdir/mvnw -q \
- -f ${rootdir}/build/maven/pom-catalog.xml \
- -Dcatalog.path=${rootdir}/resources \
- -Druntime.version=$runtimeVersion \
- -B \
- -U \
- "$@"
+ # the catalog was already provided by Camel K runtime. No need to depends on maven to rebuild it
+ wget -q https://repo1.maven.org/maven2/org/apache/camel/k/camel-k-catalog/$runtimeVersion/camel-k-catalog-$runtimeVersion-catalog.yaml -O ${rootdir}/resources/camel-catalog-$runtimeVersion.yaml
+ # TODO if we need to use also staging, then we must parse the maven-metadata from the staging repository
Review comment:
I don't think so, but we'll discover while releasing probably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3123: fix(ci): remove unused maven references
Posted by GitBox <gi...@apache.org>.
squakez merged pull request #3123:
URL: https://github.com/apache/camel-k/pull/3123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a change in pull request #3123: fix(ci): remove unused maven references
Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #3123:
URL: https://github.com/apache/camel-k/pull/3123#discussion_r828155893
##########
File path: script/get_catalog.sh
##########
@@ -21,14 +21,12 @@ rootdir=$location/../
if [ "$#" -ge 1 ]; then
runtimeVersion="$1"
shift 1
- $rootdir/mvnw -q \
- -f ${rootdir}/build/maven/pom-catalog.xml \
- -Dcatalog.path=${rootdir}/resources \
- -Druntime.version=$runtimeVersion \
- -B \
- -U \
- "$@"
+ # the catalog was already provided by Camel K runtime. No need to depends on maven to rebuild it
+ wget -q https://repo1.maven.org/maven2/org/apache/camel/k/camel-k-catalog/$runtimeVersion/camel-k-catalog-$runtimeVersion-catalog.yaml -O ${rootdir}/resources/camel-catalog-$runtimeVersion.yaml
+ # TODO if we need to use also staging, then we must parse the maven-metadata from the staging repository
Review comment:
@oscerd I'd like your opinion here. When we're using stable version, we should be fine picking up the catalog built. Is there any interim situation where we're using `SNAPSHOT` (ie, during release process)? if so, I can work to include it as described in the TODO comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a change in pull request #3123: fix(ci): remove unused maven references
Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #3123:
URL: https://github.com/apache/camel-k/pull/3123#discussion_r828861154
##########
File path: script/get_catalog.sh
##########
@@ -21,14 +21,12 @@ rootdir=$location/../
if [ "$#" -ge 1 ]; then
runtimeVersion="$1"
shift 1
- $rootdir/mvnw -q \
- -f ${rootdir}/build/maven/pom-catalog.xml \
- -Dcatalog.path=${rootdir}/resources \
- -Druntime.version=$runtimeVersion \
- -B \
- -U \
- "$@"
+ # the catalog was already provided by Camel K runtime. No need to depends on maven to rebuild it
+ wget -q https://repo1.maven.org/maven2/org/apache/camel/k/camel-k-catalog/$runtimeVersion/camel-k-catalog-$runtimeVersion-catalog.yaml -O ${rootdir}/resources/camel-catalog-$runtimeVersion.yaml
+ # TODO if we need to use also staging, then we must parse the maven-metadata from the staging repository
Review comment:
Thanks. Then, I'll proceed with the other points in the PR and if all is fine I will merge. If it happens anything wrong during the release process I'll handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org