You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Sahlberg <da...@gmail.com> on 2021/06/23 19:56:05 UTC
Add a few items to svn:ignore in https://svn.apache.org/repos/asf/subversion/trunk
Hi,
I'm rebuilding TortoiseSVN to test some of the new performance enhancements
in /trunk. The TSVN source tree fetch the sources of Subversion using
svn:externals which is kind of neat. The build process creates a few build
folders: [release|debug]_[win32|x64][_static].
I would like to add these to the svn:ignore property on /trunk, this way it
would be easier to see if I have made any local modification to the
Subversion sources:
[[[
C:\Devel\tortoisesvn\ext>svn diff --depth immediates Subversion
Index: Subversion
===================================================================
--- Subversion (revision 1891001)
+++ Subversion (working copy)
Property changes on: Subversion
___________________________________________________________________
Modified: svn:ignore
## -29,7 +29,13 ##
apr-util
apr-iconv
Release
+release_win32
+release_win32_static
+release_x64
Debug
+debug_win32
+debug_win32_static
+debug_x64
ipch
subversion_msvc.dsw
subversion_msvc.ncb
C:\Devel\tortoisesvn\ext>
]]]
As a side note there are already a bunch of ignores for build directories,
Release/Debug just above and there is also a "db4-win32" so I think there
is a precedence to add these. Any opinions?
Kind regards,
Daniel Sahlberg
Re: Add a few items to svn:ignore in https://svn.apache.org/repos/asf/subversion/trunk
Posted by Daniel Sahlberg <da...@gmail.com>.
Den tors 24 juni 2021 kl 00:37 skrev Daniel Shahaf <d....@daniel.shahaf.name>:
> The pattern matches release_x64_static and debug_x64_static, but they
> haven't been added to the property's value. Should they?
>
They were not present on my dev rig but I don't know if that is because of
the way I did the build. Anyway, with Mark's proposed change they would be
handled, should they appear.
> As to the log message, the syntax of the multiple-filenames-describing
> thing doesn't matter too much; it's clear what you meant, and that's
> what matters. For reference, something like "Ignore TortoiseSVN build
> directories", without naming the directories at all, would have been
> acceptable too (which, incidentally, is why the "Don't hide names in
> wildcards" rule in HACKING doesn't apply too strongly in this case).
>
Thanks for the feedback!
/Daniel
Re: Add a few items to svn:ignore in https://svn.apache.org/repos/asf/subversion/trunk
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Daniel Sahlberg wrote on Wed, 23 Jun 2021 21:44 +00:00:
> I've committed r1891003. My makeup regex is probably not correct, feel
> free to adjust it to something more proper.
The pattern matches release_x64_static and debug_x64_static, but they
haven't been added to the property's value. Should they?
As to the log message, the syntax of the multiple-filenames-describing
thing doesn't matter too much; it's clear what you meant, and that's
what matters. For reference, something like "Ignore TortoiseSVN build
directories", without naming the directories at all, would have been
acceptable too (which, incidentally, is why the "Don't hide names in
wildcards" rule in HACKING doesn't apply too strongly in this case).
I suppose that's a use-case for being able to «blame» property values.
Calling «[release|debug]_[win32|x64][_static]» a regex is a bit
confusing, since in most/all regex flavours, an unescaped square bracket
denotes an "any one of the following characters" alternation. It _is_
a regex, in that it matches strings using literals, alternations, and
Kleene stars, but matching the description "My regex" against the log
message did involve some backtracking ;-)
Cheers,
Daniel
Re: Add a few items to svn:ignore in https://svn.apache.org/repos/asf/subversion/trunk
Posted by Daniel Sahlberg <da...@gmail.com>.
Den ons 23 juni 2021 kl 22:38 skrev Stefan Sperling <st...@apache.org>:
> I don't see any reason against adding these. +1
>
Thanks!
I've committed r1891003. My makeup regex is probably not correct, feel
free to adjust it to something more proper.
Kind regards,
Daniel Sahlberg
Re: Add a few items to svn:ignore in
https://svn.apache.org/repos/asf/subversion/trunk
Posted by Stefan Sperling <st...@apache.org>.
On Wed, Jun 23, 2021 at 09:56:05PM +0200, Daniel Sahlberg wrote:
> Hi,
>
> I'm rebuilding TortoiseSVN to test some of the new performance enhancements
> in /trunk. The TSVN source tree fetch the sources of Subversion using
> svn:externals which is kind of neat. The build process creates a few build
> folders: [release|debug]_[win32|x64][_static].
>
> I would like to add these to the svn:ignore property on /trunk, this way it
> would be easier to see if I have made any local modification to the
> Subversion sources:
>
> [[[
> C:\Devel\tortoisesvn\ext>svn diff --depth immediates Subversion
> Index: Subversion
> ===================================================================
> --- Subversion (revision 1891001)
> +++ Subversion (working copy)
>
> Property changes on: Subversion
> ___________________________________________________________________
> Modified: svn:ignore
> ## -29,7 +29,13 ##
> apr-util
> apr-iconv
> Release
> +release_win32
> +release_win32_static
> +release_x64
> Debug
> +debug_win32
> +debug_win32_static
> +debug_x64
> ipch
> subversion_msvc.dsw
> subversion_msvc.ncb
>
> C:\Devel\tortoisesvn\ext>
> ]]]
>
> As a side note there are already a bunch of ignores for build directories,
> Release/Debug just above and there is also a "db4-win32" so I think there
> is a precedence to add these. Any opinions?
I don't see any reason against adding these. +1
Cheers,
Stefan