You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/09 16:25:20 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request, #968: Add gets the current day of year.
arturobernalg opened a new pull request, #968:
URL: https://github.com/apache/commons-lang/pull/968
Add method to gets the current day of year given a calendar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a diff in pull request #968: Add gets the current day of year.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on code in PR #968:
URL: https://github.com/apache/commons-lang/pull/968#discussion_r990824077
##########
src/main/java/org/apache/commons/lang3/time/CalendarUtils.java:
##########
@@ -77,6 +77,16 @@ public int getDayOfMonth() {
return calendar.get(Calendar.DAY_OF_MONTH);
}
+ /**
+ * Gets the current day of year.
+ *
+ * @return the current day of year.
+ * @since 3.12.1
Review Comment:
done. Set to 3.13.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #968: Add gets the current day of year.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #968:
URL: https://github.com/apache/commons-lang/pull/968#discussion_r990816437
##########
src/main/java/org/apache/commons/lang3/time/CalendarUtils.java:
##########
@@ -77,6 +77,16 @@ public int getDayOfMonth() {
return calendar.get(Calendar.DAY_OF_MONTH);
}
+ /**
+ * Gets the current day of year.
+ *
+ * @return the current day of year.
+ * @since 3.12.1
Review Comment:
Wrong version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a diff in pull request #968: Add gets the current day of year.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on code in PR #968:
URL: https://github.com/apache/commons-lang/pull/968#discussion_r990824077
##########
src/main/java/org/apache/commons/lang3/time/CalendarUtils.java:
##########
@@ -77,6 +77,16 @@ public int getDayOfMonth() {
return calendar.get(Calendar.DAY_OF_MONTH);
}
+ /**
+ * Gets the current day of year.
+ *
+ * @return the current day of year.
+ * @since 3.12.1
Review Comment:
done. I ser 3.13.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #968: Add gets the current day of year.
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #968:
URL: https://github.com/apache/commons-lang/pull/968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #968: Add gets the current day of year.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #968:
URL: https://github.com/apache/commons-lang/pull/968#issuecomment-1272580252
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#968](https://codecov.io/gh/apache/commons-lang/pull/968?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ca5d1b) into [master](https://codecov.io/gh/apache/commons-lang/commit/b6d39a4257c46672e915098a156f63cd0a713a72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6d39a4) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #968 +/- ##
=========================================
Coverage 91.99% 92.00%
- Complexity 7432 7434 +2
=========================================
Files 189 189
Lines 15664 15665 +1
Branches 2907 2907
=========================================
+ Hits 14410 14412 +2
Misses 677 677
+ Partials 577 576 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/commons/lang3/time/CalendarUtils.java](https://codecov.io/gh/apache/commons-lang/pull/968/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvdGltZS9DYWxlbmRhclV0aWxzLmphdmE=) | `90.00% <100.00%> (+0.52%)` | :arrow_up: |
| [...apache/commons/lang3/reflect/ConstructorUtils.java](https://codecov.io/gh/apache/commons-lang/pull/968/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvcmVmbGVjdC9Db25zdHJ1Y3RvclV0aWxzLmphdmE=) | `86.00% <0.00%> (+2.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org