You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/02 10:28:28 UTC

[GitHub] [flink] BiGsuw commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

BiGsuw commented on code in PR #19590:
URL: https://github.com/apache/flink/pull/19590#discussion_r862741340


##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonBatchFileSystemITCase.java:
##########
@@ -50,11 +54,27 @@ public String[] formatProperties() {
     }
 
     @Test
-    public void testParseError() throws Exception {
-        String path = new URI(resultPath()).getPath();
+    void testParseError(@TempDir java.nio.file.Path temporaryFolder) throws Exception {
+        String sql =

Review Comment:
   ok, i'm changing it back to junit4 now, so @RegisterExtension and @TempDir won't work because they need junit5, i'm back to @Rule



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org