You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Kočí (JIRA)" <de...@myfaces.apache.org> on 2010/08/13 23:00:18 UTC

[jira] Created: (MYFACES-2879) Cache introspection information about converters

Cache introspection information about converters
------------------------------------------------

                 Key: MYFACES-2879
                 URL: https://issues.apache.org/jira/browse/MYFACES-2879
             Project: MyFaces Core
          Issue Type: Improvement
          Components: General
    Affects Versions: 2.0.2-SNAPSHOT
         Environment: myfaces trunk
            Reporter: Martin Kočí
            Priority: Minor


org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class<?>) should cache information about constructor and other ones. Stress test detected that this part of code catches NoSuchMethodException too many times (million times in 10 minutes with my tests!)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2879) Cache introspection information about converters

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Korherr resolved MYFACES-2879.
------------------------------------

    Fix Version/s: 1.2.10-SNAPSHOT
                   2.0.2-SNAPSHOT
       Resolution: Fixed

Now the information about the constructor is cached in a List<Class<? extends Converter>> in ApplicationImpl. Thus the NoSuchMethodException will only be thrown once for every converter class that does not support the one-arg constructor.

Just to be sure I also tested this caching mechanism in a shared-classloader scenario, and everything worked fine!

> Cache introspection information about converters
> ------------------------------------------------
>
>                 Key: MYFACES-2879
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2879
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 1.2.10-SNAPSHOT, 2.0.2-SNAPSHOT
>         Environment: myfaces trunk
>            Reporter: Martin Kočí
>            Assignee: Jakob Korherr
>            Priority: Minor
>             Fix For: 1.2.10-SNAPSHOT, 2.0.2-SNAPSHOT
>
>
> org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class<?>) should cache information about constructor and other ones. Stress test detected that this part of code catches NoSuchMethodException too many times (million times in 10 minutes with my tests!)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.