You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/07 09:41:04 UTC
[GitHub] [cordova-plugin-splashscreen] HansKrywaa opened a new pull request #286: (docs): Add Information about how to use Dark Mode SplasScreens
HansKrywaa opened a new pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Just a Documentation Change
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Dark Mode SplashScreens now work on both: iOS and Android. To let people know how to use them i created this documentation change. #246
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [X] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] terreng commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
terreng commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670575374
Perhaps mention supported iOS (13+) and Android (9+) versions? iOS 12 and below will use whichever splashscreen does not have a luminosity suffix specified (the default one).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] HansKrywaa commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
HansKrywaa commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670921978
@erisu Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] breautek commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670576028
> Perhaps mention supported iOS (13+) and Android (9+) versions? iOS 12 and below will use whichever splashscreen does not have a luminosity suffix specified (the default one).
Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670922132
@HansKrywaa merged, thank you for the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] HansKrywaa commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
HansKrywaa commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670855200
@terreng adjusted 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu merged pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] HansKrywaa commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
HansKrywaa commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670727023
Updated 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] breautek commented on pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#issuecomment-670545084
Travis is failing due to another unrelated issue.
Because this is simply a docs change I think it's safe to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] terreng commented on a change in pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
terreng commented on a change in pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#discussion_r467337709
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode (API 28+)
+
+You can easily provide an extra SplashScreen image for NightMode/DarkMode enabled devices.
+To do this, add the keyword `-night` in between the image's **layout** and **size** keywords of the `density` attribute value. E.g.: `land-night-hdpi`
Review comment:
```suggestion
To do this, add the `-night` keyword in between the **layout** and **size** keywords of the image's `density` attribute value. E.g.: `land-night-hdpi`
```
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode (API 28+)
+
+You can easily provide an extra SplashScreen image for NightMode/DarkMode enabled devices.
Review comment:
```suggestion
You can optionally provide an extra SplashScreen image to be used in dark/night mode when enabled on supported devices.
```
##########
File path: README.md
##########
@@ -343,6 +367,23 @@ The above looks like the following in `config.xml`:
<splash src="res/screen/ios/Default@2x~ipad~comany.png" />
```
+##### Dark Mode
+
+Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to use optionally different splashscreen images when your app is running in dark mode. You can configure these images in config.xml with the ~dark suffix (and ~light is also supported).
+
+```xml
+<!-- Default image to be used for all modes -->
+<splash src="res/screen/ios/Default@2x~universal~anyany.png" />
+
+<!-- Image to use specifically for dark mode devices -->
+<splash src="res/screen/ios/Default@2x~universal~anyany~dark.png" />
+
+<!-- Image to use specifically for light mode devices -->
+<splash src="res/screen/ios/Default@2x~universal~anyany~light.png" />
+```
+
+**Note:** This works since iOS13+. Version below will use the default SplashScreen without a luminosity suffix specified.
Review comment:
```suggestion
**Note:** This works since iOS 13. iOS 12 and below will use the default SplashScreen without a luminosity suffix specified.
```
##########
File path: README.md
##########
@@ -343,6 +367,23 @@ The above looks like the following in `config.xml`:
<splash src="res/screen/ios/Default@2x~ipad~comany.png" />
```
+##### Dark Mode
+
+Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to use optionally different splashscreen images when your app is running in dark mode. You can configure these images in config.xml with the ~dark suffix (and ~light is also supported).
Review comment:
```suggestion
Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to optionally specify different SplashScreen images to be used when your app is running in dark mode. You can specify the luminosity of SplashScreen images in config.xml using the ~dark and ~light suffixes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a change in pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#discussion_r467094143
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode
+
+You can easily provide an extra SplashScreen Image for NightMode/DarkMode enabled Devices.
+Do this by addign **-night** at the correct Place in the `density`.
Review comment:
```suggestion
To do this, add the keyword `-night` in between the image's **layout** and **size** keywords of the `density` attribute value. E.g.: `land-night-hdpi`
```
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode
+
+You can easily provide an extra SplashScreen Image for NightMode/DarkMode enabled Devices.
Review comment:
```suggestion
You can easily provide an extra SplashScreen image for NightMode/DarkMode enabled devices.
```
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode
+
+You can easily provide an extra SplashScreen Image for NightMode/DarkMode enabled Devices.
+Do this by addign **-night** at the correct Place in the `density`.
+
+The correct Place is between the Image Layout and the Size. See [the Example Configuration](#example-android-configuration).
Review comment:
```suggestion
For more examples, please see [the Example Configuration](#example-android-configuration) section.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a change in pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#discussion_r467459031
##########
File path: README.md
##########
@@ -343,6 +367,23 @@ The above looks like the following in `config.xml`:
<splash src="res/screen/ios/Default@2x~ipad~comany.png" />
```
+##### Dark Mode
+
+Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to optionally specify different SplashScreen images to be used when your app is running in dark mode. You can specify the luminosity of SplashScreen images in config.xml using the ~dark and ~light suffixes.
Review comment:
```suggestion
Since [Cordova-iOS@6.1.0](https://github.com/apache/cordova-ios), it is now possible to optionally specify different SplashScreen images to use when the app is running in dark mode. The luminosity of SplashScreen images can be defined in `config.xml` using the `~dark` and `~light` suffixes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org