[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #108: Reorder text processing, tweak mention format, escape tilde

[GitBox <gi...@apache.org>]

mocobeta commented on code in PR #108:
URL: https://github.com/apache/lucene-jira-archive/pull/108#discussion_r936795269


##########
migration/src/jira_util.py:
##########
@@ -287,9 +276,23 @@ def escape_gh_issue_link(m: re.Match):
             disp_name = jira_users.get(jira_id)
             gh_m = account_map.get(jira_id)
             # replace Jira name with GitHub account or Jira display name if it is available, othewise show Jira name with ``
-            mention = lambda: f"@{gh_m}" if gh_m else disp_name if disp_name else f"`~{jira_id}`"
+            mention = lambda: f"@{gh_m}" if gh_m else disp_name if disp_name else f"`@{jira_id}`"

Review Comment:
   Use `@` instead of `~` for mentions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org