[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #586: [FLINK-32002] Adjust autoscaler defaults for release

["gyfora (via GitHub)" <gi...@apache.org>]

gyfora commented on code in PR #586:
URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1187275934


##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java:
##########
@@ -87,28 +88,28 @@ private static ConfigOptions.OptionBuilder autoScalerConfig(String key) {
     public static final ConfigOption<Integer> VERTEX_MAX_PARALLELISM =
             autoScalerConfig("vertex.max-parallelism")
                     .intType()
-                    .defaultValue(Integer.MAX_VALUE)
+                    .defaultValue(200)
                     .withDescription(
                             "The maximum parallelism the autoscaler can use. Note that this limit will be ignored if it is higher than the max parallelism configured in the Flink config or directly on each operator.");
 
     public static final ConfigOption<Double> MAX_SCALE_DOWN_FACTOR =
             autoScalerConfig("scale-down.max-factor")
                     .doubleType()
-                    .defaultValue(0.6)
+                    .defaultValue(1.0)

Review Comment:
   I tend to agree here, I think 0.6 is not a bad default. I could also see 0.7 to be good as well but I would not go higher than that because often a large scale down leads to an immediate scale up due to non-linearity



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org