You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/06/09 12:13:26 UTC

[GitHub] [ignite] timoninmaxim commented on pull request #9081: IGNITE-14703. Add MergeSort distributed cache query reducer.

timoninmaxim commented on pull request #9081:
URL: https://github.com/apache/ignite/pull/9081#issuecomment-857642340


   Hi @AMashenkov ! Thanks for comments, I refactored code and make it more clear:
   1. Move all reducers to separate package, make PageStream, NodePageStream top level classes;
   2. Remove custom logic from NodePageStream (now it just wrapper over PageStream with single node) and leverage on PageStream only. It also helps to simplify logic of MergeSortReducer;
   3. Reworked CacheQueryReducer interface: added callback methods (onError, onCancel, onFinish), removed/renamed and fixed doc for unclear methods, moving some methods to top level hierarchy class.
   
   Could you please review PR again? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org