Re: [VOTE] log4cxx 0.10.0 release candidate 6

[Jostein Tveit <jo...@pvv.ntnu.no>]

Curt Arnold <ca...@apache.org> writes:

>> datetimedateformattestcase fails with
>> Line 213: expected <avr>, but saw <Apr>
>
> In this unit test, the locale is set to fr_FR and the abbreviated
> name  for the month of April generated by calling
> SimpleDateFormat and also  by calling
> DateTimeDateFormatTestCase::formatDate.  These are expected  to
> give the same value, but apparently don't with the
> DateTimeDateFormatTestCase::formatDate apparently returning
> "avr" (abbreviation for Avril) and SimpleDateFormat::format
> returning  "Apr".  The comparison function is similar but simpler
> than the  SimpleDateFormat, but should be expected to result in
> the same value.   The most significant differences is that the
> DateTimeDateFormatTestCase::formatDate() uses std::time_put<char>
> and  SimpleDateFormat would use std::time_put<wchar_t>.  It could
> be that  implementation of standard C++ library does not give
> consistent  results when the character type is changed.

I have to dig more into this, but it may be some kind of bug in
the Sun standard C++ library. I have searched the Sun site and
have found some other locale bugs.

>> sizebasedrollingtest fails with
>> Line 342: true != File("output/sbr-test6.0.zip").exists(p)
>
> Likely that you do not have a "zip" command on your path.
> RollingFileAppender uses gzip or zip if the file pattern ends
> with  ".gz" or ".zip" respectively to compress the file after
> rollover.  The  need to have sed, gzip and zip available to pass
> the unit tests is  documented for the Windows platforms, but all
> the Unix platforms  tested can with gzip, zip and sed as part of
> their default tool set.

You are correct. zip were not install on my Solaris box. After
installing the SUNWzip package, the unit test were successful.

> Unfortunately, now less than 72 hours before a trip which means either:
>
> [list of options removed]

log4cxx is in desperate need of a stable release. As long as the
problems I have found most likely are with regards to the unit
tests, I hope RC7 or RC8 will be released as log4cxx-0.10.0.

You're doing a great job here!

-- 
Jostein Tveit <jo...@pvv.ntnu.no>