You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Created) (JIRA)" <ji...@apache.org> on 2012/03/07 00:39:57 UTC
[jira] [Created] (QPID-3888) make the SimpleQueueEntryList Iterator
clean the list node structure during operation
make the SimpleQueueEntryList Iterator clean the list node structure during operation
-------------------------------------------------------------------------------------
Key: QPID-3888
URL: https://issues.apache.org/jira/browse/QPID-3888
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Fix For: 0.15
Make the SimpleQueueEntryList Iterator clean the list node structure during operation by using the getNextValidEntry() method rather than getNextNode() method.
This will result in the HouseKeeping thread performing cleanup similar to that of the scavenge() process, though far less aggressively. In concert with the message delivery processes now also using getNextValidEntry() this will allow the queue to be more self-cleaning, enabling us to work toward simply removing the explicit scavenge() calls which can hinder performance when using selectors and/or having vast numbers of messages on a queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-3888) make the SimpleQueueEntryList
Iterator clean the list node structure during operation
Posted by "Robbie Gemmell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3888:
------------------------------------
Assignee: Rob Godfrey (was: Robbie Gemmell)
Hi Rob,
Can you review this change please? I havent actually gone so far as removing scavenge yet, I'd like to rework HouseKeeping a bit to make it much more frequent before doing that, this is just a little something that needs done before we could remove it.
Robbie
> make the SimpleQueueEntryList Iterator clean the list node structure during operation
> -------------------------------------------------------------------------------------
>
> Key: QPID-3888
> URL: https://issues.apache.org/jira/browse/QPID-3888
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> Make the SimpleQueueEntryList Iterator clean the list node structure during operation by using the getNextValidEntry() method rather than getNextNode() method.
> This will result in the HouseKeeping thread performing cleanup similar to that of the scavenge() process, though far less aggressively. In concert with the message delivery processes now also using getNextValidEntry() this will allow the queue to be more self-cleaning, enabling us to work toward simply removing the explicit scavenge() calls which can hinder performance when using selectors and/or having vast numbers of messages on a queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-3888) make the SimpleQueueEntryList Iterator
clean the list node structure during operation
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3888:
---------------------------------
Status: Ready To Review (was: In Progress)
> make the SimpleQueueEntryList Iterator clean the list node structure during operation
> -------------------------------------------------------------------------------------
>
> Key: QPID-3888
> URL: https://issues.apache.org/jira/browse/QPID-3888
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> Make the SimpleQueueEntryList Iterator clean the list node structure during operation by using the getNextValidEntry() method rather than getNextNode() method.
> This will result in the HouseKeeping thread performing cleanup similar to that of the scavenge() process, though far less aggressively. In concert with the message delivery processes now also using getNextValidEntry() this will allow the queue to be more self-cleaning, enabling us to work toward simply removing the explicit scavenge() calls which can hinder performance when using selectors and/or having vast numbers of messages on a queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-3888) make the SimpleQueueEntryList
Iterator clean the list node structure during operation
Posted by "Rob Godfrey (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved QPID-3888.
-------------------------------
Resolution: Fixed
looks good to me
> make the SimpleQueueEntryList Iterator clean the list node structure during operation
> -------------------------------------------------------------------------------------
>
> Key: QPID-3888
> URL: https://issues.apache.org/jira/browse/QPID-3888
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Rob Godfrey
> Fix For: 0.15
>
>
> Make the SimpleQueueEntryList Iterator clean the list node structure during operation by using the getNextValidEntry() method rather than getNextNode() method.
> This will result in the HouseKeeping thread performing cleanup similar to that of the scavenge() process, though far less aggressively. In concert with the message delivery processes now also using getNextValidEntry() this will allow the queue to be more self-cleaning, enabling us to work toward simply removing the explicit scavenge() calls which can hinder performance when using selectors and/or having vast numbers of messages on a queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org