You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2024/09/11 14:49:01 UTC

[PR] buid(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

hainenber opened a new pull request, #30242:
URL: https://github.com/apache/superset/pull/30242

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   buid(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk`
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Upgrade major versions for dependencies of `@superset/embedded-sdk`
   - Fix `npm audit` findings
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #30242:
URL: https://github.com/apache/superset/pull/30242#issuecomment-2345079569

   Thanks @rusackas! Great power comes with great responsibility for me from now on :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30242:
URL: https://github.com/apache/superset/pull/30242#issuecomment-2345077208

   We're going to have to make you a committer, so you can make branches on `superset` and review PRs, and I can repay the favor (at least a little) by helping to rebase things for you when needed ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #30242:
URL: https://github.com/apache/superset/pull/30242#discussion_r1754860714


##########
superset-embedded-sdk/package.json:
##########
@@ -34,20 +34,20 @@
   ],
   "dependencies": {
     "@superset-ui/switchboard": "^0.20.2",
-    "jwt-decode": "^3.1.2"
+    "jwt-decode": "^4.0.0"

Review Comment:
   Very small chance of breaking changes according to the [release](https://github.com/auth0/jwt-decode/releases/tag/v4.0.0) aside from named export change. The largest risk comes from `atob` polyfill drop but since the SDK's caniuses consist of all major version, this shouldn't be an issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #30242:
URL: https://github.com/apache/superset/pull/30242#discussion_r1754835122


##########
superset-embedded-sdk/package.json:
##########
@@ -34,20 +34,20 @@
   ],
   "dependencies": {
     "@superset-ui/switchboard": "^0.20.2",
-    "jwt-decode": "^3.1.2"
+    "jwt-decode": "^4.0.0"
   },
   "devDependencies": {
-    "@babel/cli": "^7.16.8",
-    "@babel/core": "^7.16.12",
-    "@babel/preset-env": "^7.16.11",
-    "@babel/preset-typescript": "^7.16.7",
+    "@babel/cli": "^7.25.6",
+    "@babel/core": "^7.25.2",
+    "@babel/preset-env": "^7.25.4",
+    "@babel/preset-typescript": "^7.24.7",
     "@types/jest": "^29.5.12",
-    "axios": "^1.6.0",
-    "babel-loader": "^8.2.3",
+    "axios": "^1.7.7",
+    "babel-loader": "^9.1.3",

Review Comment:
   No breaking change for this major version upgrade except higher requirement of `node`, `babel` and `webpack` ([source](https://github.com/babel/babel-loader/releases/tag/v9.0.0)). All are satisfied by current versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #30242:
URL: https://github.com/apache/superset/pull/30242#discussion_r1754835122


##########
superset-embedded-sdk/package.json:
##########
@@ -34,20 +34,20 @@
   ],
   "dependencies": {
     "@superset-ui/switchboard": "^0.20.2",
-    "jwt-decode": "^3.1.2"
+    "jwt-decode": "^4.0.0"
   },
   "devDependencies": {
-    "@babel/cli": "^7.16.8",
-    "@babel/core": "^7.16.12",
-    "@babel/preset-env": "^7.16.11",
-    "@babel/preset-typescript": "^7.16.7",
+    "@babel/cli": "^7.25.6",
+    "@babel/core": "^7.25.2",
+    "@babel/preset-env": "^7.25.4",
+    "@babel/preset-typescript": "^7.24.7",
     "@types/jest": "^29.5.12",
-    "axios": "^1.6.0",
-    "babel-loader": "^8.2.3",
+    "axios": "^1.7.7",
+    "babel-loader": "^9.1.3",

Review Comment:
   No breaking change for this major version upgrade except higher requirement of `node`, `babel` and `webpack`. All are satisfied by current versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #30242:
URL: https://github.com/apache/superset/pull/30242#issuecomment-2345078439

   Rebased :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #30242:
URL: https://github.com/apache/superset/pull/30242#discussion_r1754860714


##########
superset-embedded-sdk/package.json:
##########
@@ -34,20 +34,20 @@
   ],
   "dependencies": {
     "@superset-ui/switchboard": "^0.20.2",
-    "jwt-decode": "^3.1.2"
+    "jwt-decode": "^4.0.0"

Review Comment:
   Very small chance of breaking changes according to the [release](https://github.com/auth0/jwt-decode/releases/tag/v4.0.0) aside from named export change. The largest risk comes from `atob` polyfill drop but since the SDK's caniuses consist of all major browser's latest versions, this shouldn't be an issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30242:
URL: https://github.com/apache/superset/pull/30242#issuecomment-2344830515

   Thanks @hainenber - if you bump the patch version in package.json, this should release the new version automatically (or so it seems). This also seems to need a rebase, since I already bumped it in another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30242:
URL: https://github.com/apache/superset/pull/30242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] build(deps, deps-dev): upgrade major versions for dependencies of `@superset/embedded-sdk` [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #30242:
URL: https://github.com/apache/superset/pull/30242#discussion_r1755954082


##########
superset-embedded-sdk/package.json:
##########
@@ -34,20 +34,20 @@
   ],
   "dependencies": {
     "@superset-ui/switchboard": "^0.20.2",
-    "jwt-decode": "^3.1.2"
+    "jwt-decode": "^4.0.0"

Review Comment:
   Agreed. Thanks for looking into it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org