[GitHub] [skywalking] wu-sheng commented on a change in pull request #5293: agent plugins selector

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5293:
URL: https://github.com/apache/skywalking/pull/5293#discussion_r469105819



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -266,6 +266,11 @@
          * Control the length of the peer field.
          */
         public static int PEER_MAX_LENGTH = 200;
+
+        /**
+         * Excludes some plugins which define in plugins dir

Review comment:
       ```suggestion
            * Exclude activated plugins
   ```

##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/PluginSelector.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.plugin;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.apache.skywalking.apm.agent.core.conf.Config.Plugin.EXCLUDE_PLUGINS;
+
+public class PluginSelector {

Review comment:
       Comments required.

##########
File path: docs/en/setup/service-agent/java-agent/Plugin-list.md
##########
@@ -0,0 +1,101 @@
+- Skywalking Agent List
+    - activemq-5.x
+    - armeria-063-084
+    - armeria-085
+    - armeria-086
+    - armeria-098
+    - avro-1.x
+    - brpc-java
+    - canal-1.x
+    - cassandra-java-driver-3.x
+    - dubbo
+    - ehcache-2.x
+    - elastic-job-2.x
+    - elastic-job-3.x
+    - elasticsearch-5.x
+    - elasticsearch-6.x
+    - feign-default-http-9.x
+    - feign-pathvar-9.x
+    - finagle
+    - graphql
+    - grpc-1.x
+    - gson-2.8.x
+    - h2-1.x
+    - hbase-1.x
+    - httpasyncclient-4.x
+    - httpclient-3.x
+    - httpclient-4.x
+    - hystrix-1.x
+    - influxdb-2.x
+    - jdk-http-plugin
+    - jdk-threading-plugin
+    - jedis-2.x
+    - jetty-client-9.0
+    - jetty-client-9.x
+    - jetty-server-9.x
+    - kafka-0.11.x/1.x/2.x
+    - kotlin-coroutine
+    - lettuce-5.x
+    - light4j
+    - mariadb-2.x
+    - memcache-2.x
+    - mongodb-2.x
+    - mongodb-3.x
+    - motan-0.x
+    - mysql-5.x
+    - mysql-6.x
+    - mysql-8.x
+    - netty-socketio
+    - nutz-http-1.x
+    - nutz-mvc-annotation-1.x
+    - okhttp-3.x
+    - play-2.x
+    - postgresql-8.x
+    - pulsar
+    - quasar
+    - rabbitmq-5.x
+    - redisson-3.x
+    - resteasy-server-3.x
+    - rocketMQ-3.x
+    - rocketMQ-4.x
+    - servicecomb-0.x
+    - servicecomb-1.x
+    - sharding-jdbc-1.5.x
+    - sharding-sphere-3.x
+    - sharding-sphere-4.0.0
+    - sharding-sphere-4.1.0
+    - sharding-sphere-4.x
+    - sharding-sphere-4.x-rc3
+    - sofarpc
+    - solrj-7.x
+    - spring-annotation
+    - spring-async-annotation-5.x
+    - spring-cloud-feign-1.x
+    - spring-cloud-feign-2.x
+    - spring-cloud-gateway-2.0.x
+    - spring-cloud-gateway-2.1.x
+    - spring-concurrent-util-4.x
+    - spring-core-patch
+    - spring-kafka-2.x
+    - spring-mvc-annotation
+    - spring-mvc-annotation-3.x
+    - spring-mvc-annotation-4.x
+    - spring-mvc-annotation-5.x
+    - spring-resttemplate-4.x
+    - spring-tx
+    - spring-webflux-5.x
+    - spymemcached-2.x
+    - struts2-2.x
+    - tomcat-7.x/8.x
+    - toolkit-counter
+    - toolkit-gauge
+    - toolkit-histogram
+    - toolkit-log4j
+    - toolkit-log4j2
+    - toolkit-logback
+    - toolkit-opentracing
+    - toolkit-tag
+    - toolkit-trace
+    - undertow-2.x-plugin
+    - vertx-core-3.x
+    - zookeeper-3.4.x   

Review comment:
       @kezhenxu94 Do you have any change to use some mechanisms to check this? Such as building a mock agent core main?

##########
File path: apm-sniffer/config/agent.config
##########
@@ -90,3 +90,6 @@ logging.level=${SW_LOGGING_LEVEL:INFO}
 
 # Kafka producer configuration
 plugin.kafka.bootstrap_servers=${SW_KAFKA_BOOTSTRAP_SERVERS:localhost:9092}
+
+# exclude some plugins define in plugins dir
+plugin.exclude_plugins=${SW_EXCLUDE_PLUGINS:""}

Review comment:
       Don't open this in default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org