[GitHub] [netbeans] junichi11 commented on a diff in pull request #5534: Fixed detection of duplicate types

["junichi11 (via GitHub)" <gi...@apache.org>]

junichi11 commented on code in PR #5534:
URL: https://github.com/apache/netbeans/pull/5534#discussion_r1111429941


##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -430,18 +430,15 @@ private void checkDuplicateType(List<Expression> types) {
                 }
                 if (checkedTypes.contains(name)) {
                     createDuplicateTypeError(type, typeName);
-                    return;

Review Comment:
   I've added it for a little performance (because the next error is shown if the error is fixed) but I don't think this fix has a big problem. So, it's OK. 



##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -430,18 +430,15 @@ private void checkDuplicateType(List<Expression> types) {
                 }
                 if (checkedTypes.contains(name)) {
                     createDuplicateTypeError(type, typeName);
-                    return;
                 } else if (checkedTypes.contains(Type.BOOL)) {
                     // bool|false bool|true
                     if (Type.FALSE.equals(name) || Type.TRUE.equals(name)) {
                         createDuplicateTypeError(type, typeName);
-                        return;

Review Comment:
   Unit tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists