[GitHub] [couchdb-helm] bryopsida opened a new pull request, #119: Fix postinstall cluster domain

["bryopsida (via GitHub)" <gi...@apache.org>]

bryopsida opened a new pull request, #119:
URL: https://github.com/apache/couchdb-helm/pull/119

   <!--
   Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
   make sure you are aware of the chart technical requirements and best practices:
   
   * https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
   * https://github.com/helm/helm/tree/master/docs/chart_best_practices
   
   For a quick overview across what we will look at reviewing your PR, please read
   our review guidelines:
   
   * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
   
   Following our best practices right from the start will accelerate the review process and
   help get your PR merged quicker.
   
   When updates to your PR are requested, please add new commits and do not squash the
   history. This will make it easier to identify new changes. The PR will be squashed
   anyways when it is merged. Thanks.
   
   Please make sure you test your changes before you push them.
   -->
   
   #### What this PR does / why we need it:
   This PR updates the post install job to use the `dns.clusterDomainSuffix` value, if that value is null it will default to `cluster.local`.
   
   #### Which issue this PR fixes
   *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
     - fixes #116 
   
   #### Special notes for your reviewer:
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
   - [x] Chart Version bumped
   - [x] e2e tests pass
   - [x] Variables are documented in the README.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] willholley merged pull request #119: Fix postinstall cluster domain

["willholley (via GitHub)" <gi...@apache.org>]

willholley merged PR #119:
URL: https://github.com/apache/couchdb-helm/pull/119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] willholley commented on pull request #119: Fix postinstall cluster domain

["willholley (via GitHub)" <gi...@apache.org>]

willholley commented on PR #119:
URL: https://github.com/apache/couchdb-helm/pull/119#issuecomment-1557346592

   @bryopsida LGTM after a rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org