You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/04/02 04:43:36 UTC

Review Request 70358: ATLAS-3113: Use index query to search for active entities and better logging in java patch framework

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70358/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Kapildeo Nayak, Madhan Neethiraj, Nikhil Bonte, and Nixon Rodrigues.


Bugs: ATLAS-3113
    https://issues.apache.org/jira/browse/ATLAS-3113


Repository: atlas


Description
-------

In java patch framework - Unique attribute patch handler - to retrieve all active entities graph query is used, graph query is expensive when number of entities are large. This Jira updates the graph query to use index query and also logging enhancements.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatchHandler.java 0e707a570 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java 2882f097a 


Diff: https://reviews.apache.org/r/70358/diff/1/


Testing
-------

validated that index query retrieved active entities much faster.


Thanks,

Sarath Subramanian


Re: Review Request 70358: ATLAS-3113: Use index query to search for active entities and better logging in java patch framework

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70358/#review214257
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 2, 2019, 4:43 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70358/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 4:43 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Kapildeo Nayak, Madhan Neethiraj, Nikhil Bonte, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-3113
>     https://issues.apache.org/jira/browse/ATLAS-3113
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In java patch framework - Unique attribute patch handler - to retrieve all active entities graph query is used, graph query is expensive when number of entities are large. This Jira updates the graph query to use index query and also logging enhancements.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatchHandler.java 0e707a570 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java 2882f097a 
> 
> 
> Diff: https://reviews.apache.org/r/70358/diff/1/
> 
> 
> Testing
> -------
> 
> validated that index query retrieved active entities much faster.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>