You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/10/22 14:22:10 UTC
[GitHub] [libcloud] Kami opened a new pull request #1616: [WIP] Integration tests changes and fixes
Kami opened a new pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616
Just trying to figure out what is going on with integration tests and why they are failing / timing out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1616: Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1616: Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949719437
@c-w It looks like now tests start to fail with a different error:
```bash
E azure.core.exceptions.ResourceExistsError: (MaxStorageAccountsCountPerSubscriptionExceeded) Subscription d6d608a6-e0c8-42ae-a548-2f41793709d2 already contains 251 storage accounts in location eastus2 and the maximum allowed is 250.
E Code: MaxStorageAccountsCountPerSubscriptionExceeded
E Message: Subscription d6d608a6-e0c8-42ae-a548-2f41793709d2 already contains 251 storage accounts in location eastus2 and the maximum allowed is 250.
```
Do we need some additional subscription clean up step or similar which runs before each test run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1616: [WIP] Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949695722
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1616](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24c4685) into [trunk](https://codecov.io/gh/apache/libcloud/commit/53e5cf48c7469b01548f0c36ba870a7fd5c5f55b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53e5cf4) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1616 +/- ##
==========================================
- Coverage 83.02% 83.02% -0.01%
==========================================
Files 394 394
Lines 85234 85269 +35
Branches 9065 9070 +5
==========================================
+ Hits 70769 70795 +26
- Misses 11385 11390 +5
- Partials 3080 3084 +4
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/http.py](https://codecov.io/gh/apache/libcloud/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvaHR0cC5weQ==) | `91.17% <100.00%> (+0.06%)` | :arrow_up: |
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.55% <0.00%> (-0.34%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.43% <0.00%> (-0.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9580e2f...24c4685](https://codecov.io/gh/apache/libcloud/pull/1616?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1616: [WIP] Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949683891
@c-w CI run didn't finish yet, but locally tests seem to be failing with:
```bash
________________________________________________________________ ERROR at setup of MinioTest.test_objects_stream_iterable _________________________________________________________________
cls = <class 'integration.storage.test_minio.MinioTest'>
> ???
E ValueError: Container fff2b0bdc3 failed to start and become ready in 30 seconds (did not find "IAM initialization complete" message in container logs).
E
E Container Logs:
E API: http://172.17.0.2:9000 http://127.0.0.1:9000
E
E Console: http://172.17.0.2:42801 http://127.0.0.1:42801
E
E Documentation: https://docs.min.io
E
E WARNING: Console endpoint is listening on a dynamic port (42801), please use --console-address ":PORT" to choose a static port.
```
I didn't dig in much yet. Do you think that's related to the upstream change in the Docker image (in this case we should pin it to a known working tag and to that + update ready message) or something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami edited a comment on pull request #1616: [WIP] Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami edited a comment on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949683891
@c-w CI run didn't finish yet, but locally tests seem to be failing with:
```bash
________________________________________________________________ ERROR at setup of MinioTest.test_objects_stream_iterable _________________________________________________________________
cls = <class 'integration.storage.test_minio.MinioTest'>
> ???
E ValueError: Container fff2b0bdc3 failed to start and become ready in 30 seconds (did not find "IAM initialization complete" message in container logs).
E
E Container Logs:
E API: http://172.17.0.2:9000 http://127.0.0.1:9000
E
E Console: http://172.17.0.2:42801 http://127.0.0.1:42801
E
E Documentation: https://docs.min.io
E
E WARNING: Console endpoint is listening on a dynamic port (42801), please use --console-address ":PORT" to choose a static port.
```
I didn't dig in much yet. Do you think that's related to the upstream change in the Docker image (in this case we should pin it to a known working tag and to that + update ready message) or something else?
EDIT: CI run completed, looks like it contains the same error - https://github.com/apache/libcloud/runs/3976839689?check_suite_focus=true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1616: Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949834190
@c-w Thanks. For now, I went ahead and manually deleted storage accounts in the Azure Portal.
Going forward, as a improvement I propose adding a cleanup step which runs before each test run and also as part of a cron job (in case tests are non-gracefully terminated and tearDownClass cleanup step doesn't run).
To be on the safe side, we should probably prefix all the resources created by tests using ``libcloud-itests-`` or similar and only delete resources with that prefix (I know all the resources already use libcloud prefix, but some of the accounts already contain a bucket with libcloud name which shouldn't get deleted so this would potentially conflict).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] c-w commented on pull request #1616: Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
c-w commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949731559
@Kami I'll take a look over the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1616: [WIP] Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949693715
It looks like that the Docker image behavior has indeed changed and it appears 24c46851374ac7637238abca545f3d9cdd6960c7 will do the trick (at least it did the trick locally, still waiting for CI).
As part of this PR we now also have some timeouts in place which will hopefully make it easier and faster to troubleshoot timeout related issues (previously build was hanging for hours until default GHA job timeout kicked in and no step output was available).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1616: Integration tests changes and fixes
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1616:
URL: https://github.com/apache/libcloud/pull/1616#issuecomment-949867348
@c-w I think this should probably do it for now - fcc0d72730c94fdf55229dacf5971b3121064f13.
Will see how it behaves going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org