[jira] [Commented] (CASSANDRA-6008) Getting 'This should never happen' error at startup due to sstables missing

["John Carrino (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764847#comment-13764847 ] 

John Carrino commented on CASSANDRA-6008:
-----------------------------------------

Now that I think about this more: Doesn't this new cleanup code make it hard to restore a CF from a backup?  If there was a compaction for this CF in progress when you took down the system, when you bring it back up with new sstables for this CF, then this check will prevent you from starting.
                
> Getting 'This should never happen' error at startup due to sstables missing
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6008
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6008
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: John Carrino
>             Fix For: 2.0.1
>
>
> Exception encountered during startup: "Unfinished compactions reference missing sstables. This should never happen since compactions are marked finished before we start removing the old sstables"
> This happens when sstables that have been compacted away are removed, but they still have entries in the system.compactions_in_progress table.
> Normally this should not happen because the entries in system.compactions_in_progress are deleted before the old sstables are deleted.
> However at startup recovery time, old sstables are deleted (NOT BEFORE they are removed from the compactions_in_progress table) and then after that is done it does a truncate using SystemKeyspace.discardCompactionsInProgress
> We ran into a case where the disk filled up and the node died and was bounced and then failed to truncate this table on startup, and then got stuck hitting this exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers.
> Maybe on startup we can delete from this table incrementally as we clean stuff up in the same way that compactions delete from this table before they delete old sstables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira