[jira] [Commented] (IMPALA-4179) Remove RowBatch::MarkNeedsDeepCopy() memory management API

["Tim Armstrong (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044036#comment-17044036 ] 

Tim Armstrong commented on IMPALA-4179:
---------------------------------------

IMPALA-9156 will probably add back in one or more instances of this.

> Remove RowBatch::MarkNeedsDeepCopy() memory management API
> ----------------------------------------------------------
>
>                 Key: IMPALA-4179
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4179
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 2.8.0
>            Reporter: Tim Armstrong
>            Priority: Major
>              Labels: resource-management
>
> We should remove this API as a simplification of the memory transfer model.
> It was used in various places to manage lifetime of BufferHandles, but those can be replaced with attaching the BufferHandle + MarkFlushResources().
> It is also used to work around the fact that some memory is never returned from ExecNodes and is freed in Close(). Part of the solution is probably to add a way to attach all resources to a RowBatch before Close() and during Reset().



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org