You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2025/12/04 15:45:17 UTC

[PR] NIFI-15294 Deprecate GetAsanaObject for removal [nifi]

exceptionfactory opened a new pull request, #10601:
URL: https://github.com/apache/nifi/pull/10601

   # Summary
   
   [NIFI-15294](https://issues.apache.org/jira/browse/NIFI-15294) Deprecates the `GetAsanaObject` Processor and the `StandardAsanaClientProviderService` for removal in a subsequent release version.
   
   Current Asana components depend on the [java-asana](https://github.com/Asana/java-asana) library, which is no longer maintained, and last updated in 2022.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15294 Deprecate GetAsanaObject for removal [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10601: NIFI-15294 Deprecate GetAsanaObject for removal
URL: https://github.com/apache/nifi/pull/10601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15294 Deprecate GetAsanaObject for removal [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on code in PR #10601:
URL: https://github.com/apache/nifi/pull/10601#discussion_r2589806622


##########
nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##########
@@ -83,6 +84,7 @@
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS;
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS;
 
+@DeprecationNotice(reason = "Depends on unsupported java-asana library")

Review Comment:
   This is minor but my experience on my current project is, if we do not mention the word deprecated in the reason, there is no mention of deprecation in the UI except for a reddish brownish banner. This could be confusing to users (as I was somewhat confused). Please see [NIFI-14845](https://issues.apache.org/jira/browse/NIFI-14845). I think there should be mention that this processor and below for the controller service is deprecated because...
   This makes it very clear that this component is deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15294 Deprecate GetAsanaObject for removal [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on code in PR #10601:
URL: https://github.com/apache/nifi/pull/10601#discussion_r2589806622


##########
nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##########
@@ -83,6 +84,7 @@
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS;
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS;
 
+@DeprecationNotice(reason = "Depends on unsupported java-asana library")

Review Comment:
   This is minor but my experience on my current project is, if we do not mention the word deprecated in the reason, there is no mention of deprecation in the UI except for a reddish brownish banner. Please see [NIFI-14845](https://issues.apache.org/jira/browse/NIFI-14845). I think there should be mention that this processor and below for the controller service is deprecated because...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15294 Deprecate GetAsanaObject for removal [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on code in PR #10601:
URL: https://github.com/apache/nifi/pull/10601#discussion_r2589806622


##########
nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##########
@@ -83,6 +84,7 @@
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS;
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS;
 
+@DeprecationNotice(reason = "Depends on unsupported java-asana library")

Review Comment:
   This is minor but my experience on my current project is, if we do not mention the word deprecated in the reason, there is no mention of deprecation in the UI except for a reddish brownish banner. Please see [NIFI-14845](https://issues.apache.org/jira/browse/NIFI-14845). I think there should be mention that this processor and below for the controller service is deprecated because...
   This makes it very clear that this component is deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15294 Deprecate GetAsanaObject for removal [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10601:
URL: https://github.com/apache/nifi/pull/10601#discussion_r2589853192


##########
nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##########
@@ -83,6 +84,7 @@
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS;
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS;
 
+@DeprecationNotice(reason = "Depends on unsupported java-asana library")

Review Comment:
   Thanks @dan-s1. That sounds like something to consider at the UI or framework level. Other components with the `DeprecationNotice` annotation do not include the `deprecated`, and it seems like an anti-pattern given the name of the annotation. The description in NIFI-14845 looks like a good summary of some ways forward.



##########
nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##########
@@ -83,6 +84,7 @@
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS;
 import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS;
 
+@DeprecationNotice(reason = "Depends on unsupported java-asana library")

Review Comment:
   Thanks @dan-s1. That sounds like something to consider at the UI or framework level. Other components with the `DeprecationNotice` annotation do not include the word `deprecated`, and it seems like an anti-pattern given the name of the annotation. The description in NIFI-14845 looks like a good summary of some ways forward.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org