You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/09/26 18:12:28 UTC

[GitHub] [spark] srowen opened a new pull request, #43135: [SPARK-44442][MESOS] Remove Mesos support

srowen opened a new pull request, #43135:
URL: https://github.com/apache/spark/pull/43135

   ### What changes were proposed in this pull request?
   
   Remove Mesos resource manager support and docs, previously deprecated in Spark 3.2, for Spark 4.0.
   
   ### Why are the changes needed?
   
   Mesos is no longer supported and has been deprecated for several versions.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Other than the lack of Mesos support, no
   
   ### How was this patch tested?
   
   Existing tests.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1737316379

   I noticed the TaskState.LOST comment, but was reluctant to actually totally remove handling of this event in case the comment was wrong.
   the link to the explanation in the Mesos issue is still valid, just happens to come from a really old Mesos issue on Github


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1736613886

   > 9 lines more, and it would have been an event 10k lines removed :-)
   
   A satisfying operation, hahaha ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1737345261

   > I noticed the TaskState.LOST comment, but was reluctant to actually totally remove handling of this event in case the comment was wrong. the link to the explanation in the Mesos issue is still valid, just happens to come from a really old Mesos issue on Github
   
   fine to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1738345963

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #43135: [SPARK-44442][MESOS] Remove Mesos support
URL: https://github.com/apache/spark/pull/43135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1736713186

   https://github.com/apache/spark/blob/f6c6acbc00d2d96c43298c282e4bd8ebeb160ad1/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L814-L831
   
   Does this part need to be fixed?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1736717563

   https://github.com/apache/spark/blob/f6c6acbc00d2d96c43298c282e4bd8ebeb160ad1/core/src/main/scala/org/apache/spark/SparkContext.scala#L2728
   
   In addition, does this line of comment still need to be retained?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #43135: [SPARK-44442][MESOS] Remove Mesos support

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43135:
URL: https://github.com/apache/spark/pull/43135#issuecomment-1738202405

   It looks like the tests actually passed but showing failed - I'm not quite sure what to make of the failure in 'reporting results'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org