You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/22 17:40:06 UTC
[GitHub] [pulsar-client-go] Niennienzz opened a new pull request, #866: OAuth2 KeyFileProvider - Use the `DATA` constant as prefix
Niennienzz opened a new pull request, #866:
URL: https://github.com/apache/pulsar-client-go/pull/866
### Motivation
- Code cleanup.
### Modifications
- A minor change to use the constant instead of a repeated string.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
- [x] This change is already covered by existing tests: `TestNewAuthenticationOAuth2WithParams` in `pulsar/internal/auth/oauth2_test.go`.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
### Documentation
- Does this pull request introduce a new feature? - **No.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun commented on pull request #866: OAuth2 KeyFileProvider - Use the `DATA` constant as prefix
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #866:
URL: https://github.com/apache/pulsar-client-go/pull/866#issuecomment-1316472939
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun merged pull request #866: OAuth2 KeyFileProvider - Use the `DATA` constant as prefix
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #866:
URL: https://github.com/apache/pulsar-client-go/pull/866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun commented on pull request #866: OAuth2 KeyFileProvider - Use the `DATA` constant as prefix
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #866:
URL: https://github.com/apache/pulsar-client-go/pull/866#issuecomment-1316331488
@nodece shall we merge this patch now or close it when we're merging #883?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org