You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@knox.apache.org by kr...@apache.org on 2019/02/20 17:24:31 UTC

[knox] branch master updated: KNOX-1787 - Use same SecureRandom that DefaultAliasService used

This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git


The following commit(s) were added to refs/heads/master by this push:
     new 41aa098  KNOX-1787 - Use same SecureRandom that DefaultAliasService used
41aa098 is described below

commit 41aa098a64d6c15416ba611b5ea81df2da0aadfd
Author: Kevin Risden <kr...@apache.org>
AuthorDate: Wed Feb 20 11:27:22 2019 -0500

    KNOX-1787 - Use same SecureRandom that DefaultAliasService used
    
    Signed-off-by: Kevin Risden <kr...@apache.org>
---
 .../main/java/org/apache/knox/gateway/util/PasswordUtils.java | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/gateway-util-common/src/main/java/org/apache/knox/gateway/util/PasswordUtils.java b/gateway-util-common/src/main/java/org/apache/knox/gateway/util/PasswordUtils.java
index 55f3f2d..41a9c3e 100644
--- a/gateway-util-common/src/main/java/org/apache/knox/gateway/util/PasswordUtils.java
+++ b/gateway-util-common/src/main/java/org/apache/knox/gateway/util/PasswordUtils.java
@@ -17,11 +17,10 @@
  */
 package org.apache.knox.gateway.util;
 
-import java.security.NoSuchAlgorithmException;
 import java.security.SecureRandom;
 
 public class PasswordUtils {
-  private static final SecureRandom SECURE_RANDOM = getSecureRandom();
+  private static final SecureRandom SECURE_RANDOM = new SecureRandom();
   private static final char[] ALPHANUMERIC_CHARS = { 'a', 'b', 'c', 'd', 'e', 'f', 'g',
       'h', 'j', 'k', 'm', 'n', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w',
       'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'J', 'K',
@@ -30,14 +29,6 @@ public class PasswordUtils {
 
   private PasswordUtils() {}
 
-  private static SecureRandom getSecureRandom() {
-    try {
-      return SecureRandom.getInstanceStrong();
-    } catch (NoSuchAlgorithmException e) {
-      throw new IllegalStateException(e);
-    }
-  }
-
   public static synchronized String generatePassword(int length) {
     StringBuilder sb = new StringBuilder();
     for (int i = 0; i < length; i++) {