You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smitajoshi12 (via GitHub)" <gi...@apache.org> on 2023/08/30 13:26:48 UTC
[GitHub] [ozone] smitajoshi12 opened a new pull request, #5237: Recon: OverView Page Summary End Point Correction
smitajoshi12 opened a new pull request, #5237:
URL: https://github.com/apache/ozone/pull/5237
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #5237:
URL: https://github.com/apache/ozone/pull/5237#issuecomment-1699445187
> could you provide more details why is this change needed @smitajoshi12? I don't see much either in the jira description or here, is there a change that broke the current behaviour? when did the response change?
@dombizita The modifications introduced in the mentioned [PR](https://github.com/apache/ozone/pull/5154/files#diff-9446deb0dd230ce73af58b6a6efa055d491fba0816f973063923079e56e63efd) inadvertently caused a reversal to the previous API endpoint calls. Unfortunatly, we overlooked including this particular alteration in the set of changes. As a result, the summaries on the overview page could function properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita merged pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita merged PR #5237:
URL: https://github.com/apache/ozone/pull/5237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #5237:
URL: https://github.com/apache/ozone/pull/5237#issuecomment-1699525656
The best thing to do right now is to merge this first and then merge the OM-DB Insights PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #5237:
URL: https://github.com/apache/ozone/pull/5237#issuecomment-1700793342
Thanks @smitajoshi12 LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5237:
URL: https://github.com/apache/ozone/pull/5237#issuecomment-1699458279
> could you provide more details why is this change needed @smitajoshi12? I don't see much either in the jira description or here, is there a change that broke the current behaviour? when did the response change?
1) Arafat PR :- Arafat has created new End Point for summary information. He also chnaged overview.tsx which got merged 2 weeks ago.
https://github.com/apache/ozone/pull/5023/files#diff-9446deb0dd230ce73af58b6a6efa055d491fba0816f973063923079e56e63efd
2) Abishek PR :- while doing rebasing or current pull or merge conflict changes got reverted back which got merged 2 days before.
https://github.com/apache/ozone/pull/5154/files#diff-9446deb0dd230ce73af58b6a6efa055d491fba0816f973063923079e56e63efd
Issue is because of Rest End Point Path change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5237:
URL: https://github.com/apache/ozone/pull/5237#issuecomment-1699317360
could you provide more details why is this change needed @smitajoshi12? I don't see much either in the jira description or here, is there a change that broke the current behaviour? when did the response change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #5237: HDDS-9227. Recon: OverView Page Summary End Point Correction
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5237:
URL: https://github.com/apache/ozone/pull/5237#issuecomment-1700823431
thanks for the patch @smitajoshi12! thanks for the review @ArafatKhan2198 and @devmadhuu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org