You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by ke...@apache.org on 2008/04/17 19:52:31 UTC
svn commit: r649205 -
/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java
Author: kevan
Date: Thu Apr 17 10:52:30 2008
New Revision: 649205
URL: http://svn.apache.org/viewvc?rev=649205&view=rev
Log:
OPENEJB-793 fix infinite loop CheckCallbacks.getMethods(Class,String)
Modified:
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java
Modified: openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java?rev=649205&r1=649204&r2=649205&view=diff
==============================================================================
--- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java (original)
+++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java Thu Apr 17 10:52:30 2008
@@ -230,6 +230,7 @@
methods.add(method);
}
}
+ clazz = clazz.getSuperclass();
}
return methods;
}
Re: CheckCallbacks loop (svn commit: r649205)
Posted by Kevan Miller <ke...@gmail.com>.
On Apr 18, 2008, at 12:33 AM, David Blevins wrote:
> This looks pretty serious. How is it that we don't get stuck in
> this look all the time?
Ya. Was a bit concerned about that, myself. getMethods() is only
called when getMethod() is unable to resolve an interceptor to an
actual method. So, it's an exceptional condition and requires an error
in an ejb-jar.xml to reproduce.
--kevan
>
>
> -David
>
> On Apr 17, 2008, at 10:52 AM, kevan@apache.org wrote:
>
>> Author: kevan
>> Date: Thu Apr 17 10:52:30 2008
>> New Revision: 649205
>>
>> URL: http://svn.apache.org/viewvc?rev=649205&view=rev
>> Log:
>> OPENEJB-793 fix infinite loop CheckCallbacks.getMethods(Class,String)
>>
>> Modified:
>> openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
>> apache/openejb/config/rules/CheckCallbacks.java
>>
>> Modified: openejb/trunk/openejb3/container/openejb-core/src/main/
>> java/org/apache/openejb/config/rules/CheckCallbacks.java
>> URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java?rev=649205&r1=649204&r2=649205&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
>> apache/openejb/config/rules/CheckCallbacks.java (original)
>> +++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
>> apache/openejb/config/rules/CheckCallbacks.java Thu Apr 17 10:52:30
>> 2008
>> @@ -230,6 +230,7 @@
>> methods.add(method);
>> }
>> }
>> + clazz = clazz.getSuperclass();
>> }
>> return methods;
>> }
>>
>>
>>
>
CheckCallbacks loop (svn commit: r649205)
Posted by David Blevins <da...@visi.com>.
This looks pretty serious. How is it that we don't get stuck in this
look all the time?
-David
On Apr 17, 2008, at 10:52 AM, kevan@apache.org wrote:
> Author: kevan
> Date: Thu Apr 17 10:52:30 2008
> New Revision: 649205
>
> URL: http://svn.apache.org/viewvc?rev=649205&view=rev
> Log:
> OPENEJB-793 fix infinite loop CheckCallbacks.getMethods(Class,String)
>
> Modified:
> openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
> apache/openejb/config/rules/CheckCallbacks.java
>
> Modified: openejb/trunk/openejb3/container/openejb-core/src/main/
> java/org/apache/openejb/config/rules/CheckCallbacks.java
> URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java?rev=649205&r1=649204&r2=649205&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
> apache/openejb/config/rules/CheckCallbacks.java (original)
> +++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/
> apache/openejb/config/rules/CheckCallbacks.java Thu Apr 17 10:52:30
> 2008
> @@ -230,6 +230,7 @@
> methods.add(method);
> }
> }
> + clazz = clazz.getSuperclass();
> }
> return methods;
> }
>
>
>