You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/22 20:35:14 UTC
[kudu-CR] KUDU-1812: redact HexDump output
Hello Adar Dembo, Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5567
to review the following change.
Change subject: KUDU-1812: redact HexDump output
......................................................................
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found that all calls would require manual redaction. Instead of
requiring callers to manually redact, it's easier to do it centrally.
Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
---
M src/kudu/util/hexdump.cc
M src/kudu/util/hexdump.h
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5567/1
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812: redact HexDump output
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5567/1/src/kudu/util/hexdump.h
File src/kudu/util/hexdump.h:
PS1, Line 30: t
> nit: capitalize
Done
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1812: redact HexDump output
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
......................................................................
Patch Set 1:
(1 comment)
lgtm, just a nit
http://gerrit.cloudera.org:8080/#/c/5567/1/src/kudu/util/hexdump.h
File src/kudu/util/hexdump.h:
PS1, Line 30: t
nit: capitalize
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1812: redact HexDump output
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812: redact HexDump output
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812: redact HexDump output
......................................................................
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found that all calls would require manual redaction. Instead of
requiring callers to manually redact, it's easier to do it centrally.
Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Reviewed-on: http://gerrit.cloudera.org:8080/5567
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/hexdump.cc
M src/kudu/util/hexdump.h
2 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812: redact HexDump output
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5567
to look at the new patch set (#2).
Change subject: KUDU-1812: redact HexDump output
......................................................................
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found that all calls would require manual redaction. Instead of
requiring callers to manually redact, it's easier to do it centrally.
Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
---
M src/kudu/util/hexdump.cc
M src/kudu/util/hexdump.h
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5567/2
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812: redact HexDump output
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
......................................................................
Patch Set 2: Code-Review+2
I took a look at all the HexDump() callers, ignoring the test-only ones. There are a few places where, if there was corruption, we may get a slightly less useful log message. But, most are on read paths, where it's very likely that the corruption is deterministic and repeatable. So, asking a user to disable redaction temporarily to reproduce the corruption and yield a better error message is a possibility.
tl;dr: I'm OK with this.
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No