You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/26 21:08:01 UTC
[jira] [Commented] (BEAM-2271) Release guide or pom.xml needs
update to avoid releasing Python binary artifacts
[ https://issues.apache.org/jira/browse/BEAM-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063797#comment-16063797 ]
ASF GitHub Bot commented on BEAM-2271:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/3441
[BEAM-2271] Add more files to mvn clean
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
@aaltay I can't test this as I don't have permissions to follow the release guide. Can you test this out?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-2271-fix-release-filter-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3441
----
----
> Release guide or pom.xml needs update to avoid releasing Python binary artifacts
> --------------------------------------------------------------------------------
>
> Key: BEAM-2271
> URL: https://issues.apache.org/jira/browse/BEAM-2271
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Daniel Halperin
> Assignee: Ahmet Altay
> Fix For: 2.1.0
>
>
> The following directories (and children) were discovered in 2.0.0-RC2 and were present in 0.6.0.
> {code}
> sdks/python: build dist .eggs nose-1.3.7-py2.7.egg (and child contents)
> {code}
> Ideally, these artifacts, which are created during setup and testing, would get created in the {{sdks/python/target/}} subfolder where they will automatically get ignored. More info below.
> For 2.0.0, we will manually remove these files from the source release RC3+. This should be fixed before the next release.
> Here is a list of other paths that get excluded, should they be useful.
> {code}
> <excludes>
> <!-- build output -->
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/).*${project.build.directory}.*]</exclude>
>
> <!-- NOTE: Most of the following excludes should not be required
> if the standard release process is followed. This is because the
> release plugin checks out project sources into a location like
> target/checkout, then runs the build from there. The result is
> a source-release archive that comes from a pretty clean directory
> structure.
>
> HOWEVER, if the release plugin is configured to run extra goals
> or generate a project website, it's definitely possible that some
> of these files will be present. So, it's safer to exclude them.
> -->
>
> <!-- IDEs -->
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?maven-eclipse\.xml]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.project]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.classpath]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?[^/]*\.iws]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.idea(/.*)?]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?out(/.*)?]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?[^/]*\.ipr]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?[^/]*\.iml]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.settings(/.*)?]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.externalToolBuilders(/.*)?]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.deployables(/.*)?]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.wtpmodules(/.*)?]</exclude>
>
> <!-- misc -->
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?cobertura\.ser]</exclude>
>
> <!-- release-plugin temp files -->
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?pom\.xml\.releaseBackup]</exclude>
> <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?release\.properties]</exclude>
> </excludes>
> {code}
> This list is stored inside of this jar, which you can find by tracking maven-assembly-plugin from the root apache pom: https://mvnrepository.com/artifact/org.apache.apache.resources/apache-source-release-assembly-descriptor/1.0.6
> http://svn.apache.org/repos/asf/maven/pom/tags/apache-18/pom.xml
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)