You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Fred Oliver (JIRA)" <ji...@apache.org> on 2007/08/11 00:47:42 UTC
[jira] Created: (RIVER-233) ComputeDigest instructions reference
sha and sha1
ComputeDigest instructions reference sha and sha1
-------------------------------------------------
Key: RIVER-233
URL: https://issues.apache.org/jira/browse/RIVER-233
Project: River
Issue Type: Improvement
Components: com_sun_jini_tool
Affects Versions: jtsk_2.1
Reporter: Fred Oliver
Priority: Trivial
Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
----
Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (RIVER-233) ComputeDigest instructions
reference sha and sha1
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575833#action_12575833 ]
foliver edited comment on RIVER-233 at 3/6/08 11:05 AM:
------------------------------------------------------------
A patch file for this and related bugs (RIVER-253, RIVER-252, RIVER-233, RIVER-231)
is attached to RIVER-253.
was (Author: foliver):
A patch file for this and related bugs (RIVER-253, -252, -233, -231)
is attached to RIVER-253.
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (RIVER-233) ComputeDigest instructions
reference sha and sha1
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on RIVER-233 started by Fred Oliver.
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577532#action_12577532 ]
Fred Oliver commented on RIVER-233:
-----------------------------------
In a subsequent commit, I've change "sha1" to "SHA-1" for better consistency with other classes.
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575833#action_12575833 ]
Fred Oliver commented on RIVER-233:
-----------------------------------
A patch file for this and related bugs (RIVER-253, -252, -233, -231)
is attached to RIVER-253.
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fred Oliver updated RIVER-233:
------------------------------
Fix Version/s: AR2
Assignee: Fred Oliver
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (RIVER-233) ComputeDigest instructions reference sha
and sha1
Posted by "Peter Firmstone (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Firmstone closed RIVER-233.
---------------------------------
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by Fred Oliver <Fr...@Sun.COM>.
While code consistency is good, I feel that this particular set of
changes is not worth the effort and not worth filing and issue for.
Fred
Mark Brouwer wrote:
> Fred Oliver wrote:
>> Mark,
>>
>> In a subsequent commit, I've change "sha1" to "SHA-1" for better
>> consistency with other classes, as you suggested. Using "sha", "sha1",
>> "SHA", and "SHA-1" all produce the same result.
>
> Ok, thanks. Do you think it is a good idea to make all code consistent
> and file an issue for it, or is it OK as is?
Re: [jira] Resolved: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by Mark Brouwer <ma...@cheiron.org>.
Fred Oliver wrote:
> Mark,
>
> In a subsequent commit, I've change "sha1" to "SHA-1" for better
> consistency with other classes, as you suggested. Using "sha", "sha1",
> "SHA", and "SHA-1" all produce the same result.
Ok, thanks. Do you think it is a good idea to make all code consistent
and file an issue for it, or is it OK as is?
--
Mark
Re: [jira] Resolved: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by Fred Oliver <Fr...@Sun.COM>.
Mark,
In a subsequent commit, I've change "sha1" to "SHA-1" for better
consistency with other classes, as you suggested. Using "sha", "sha1",
"SHA", and "SHA-1" all produce the same result.
Fred
Mark Brouwer wrote:
> Fred Oliver (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Fred Oliver resolved RIVER-233.
>> -------------------------------
>>
>> Resolution: Fixed
>>
>>> ComputeDigest instructions reference sha and sha1
>>> -------------------------------------------------
>>>
>>> Key: RIVER-233
>>> URL: https://issues.apache.org/jira/browse/RIVER-233
>>> Project: River
>>> Issue Type: Improvement
>>> Components: com_sun_jini_tool
>>> Affects Versions: jtsk_2.1
>>> Reporter: Fred Oliver
>>> Assignee: Fred Oliver
>>> Priority: Trivial
>>> Fix For: AR2
>>>
>>>
>>> Bugtraq ID
>>> [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
>>> The example use of the ComputeDigest tool in the class javadoc uses
>>> 'sha' as an example algorithm when the default algorithm is later
>>> specified to be 'sha1'. My understanding is that sha and sha1 are
>>> the same (they certainly produce the same digest). Perhaps it would
>>> be better for the example to use a non-sha algorithm (or at least a
>>> non-sha1 algorithm since that is the default).
>>> ----
>>> Consistenly using "sha1" should be satisfactory.
>>
>
> Hi Fred,
>
> I'm working on JarWrapper and in the code and javadoc the message digest
> is referenced as SHA-1, and I noticed that for ComputeDigest this is now
> referred to as sha1.
>
> I did a quick look in the complete codebase and it seems that in almost
> all cases SHA-1 is used opposed to sha1. But also that there are a few
> places where the following is used:
>
> MessageDigest.getInstance("SHA")
>
> While in the javadoc it is stated that SHA-1 is used. Are we dealing
> with the some 'inconsistency', if so should this be corrected. I must
> admit that due to this inconsistent usage of capitals, a dash, or a
> combination I never understood what the correct name is (even while it
> doesn't matter in practice).
>
> I'm all for a consistent naming of message digest algorithms and would
> like to 'fix' this but maybe I'm missing some subtleties here.
>
> Thanks,
Re: [jira] Resolved: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by Mark Brouwer <ma...@cheiron.org>.
Fred Oliver (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Fred Oliver resolved RIVER-233.
> -------------------------------
>
> Resolution: Fixed
>
>> ComputeDigest instructions reference sha and sha1
>> -------------------------------------------------
>>
>> Key: RIVER-233
>> URL: https://issues.apache.org/jira/browse/RIVER-233
>> Project: River
>> Issue Type: Improvement
>> Components: com_sun_jini_tool
>> Affects Versions: jtsk_2.1
>> Reporter: Fred Oliver
>> Assignee: Fred Oliver
>> Priority: Trivial
>> Fix For: AR2
>>
>>
>> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
>> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
>> ----
>> Consistenly using "sha1" should be satisfactory.
>
Hi Fred,
I'm working on JarWrapper and in the code and javadoc the message digest
is referenced as SHA-1, and I noticed that for ComputeDigest this is now
referred to as sha1.
I did a quick look in the complete codebase and it seems that in almost
all cases SHA-1 is used opposed to sha1. But also that there are a few
places where the following is used:
MessageDigest.getInstance("SHA")
While in the javadoc it is stated that SHA-1 is used. Are we dealing
with the some 'inconsistency', if so should this be corrected. I must
admit that due to this inconsistent usage of capitals, a dash, or a
combination I never understood what the correct name is (even while it
doesn't matter in practice).
I'm all for a consistent naming of message digest algorithms and would
like to 'fix' this but maybe I'm missing some subtleties here.
Thanks,
--
Mark
[jira] Resolved: (RIVER-233) ComputeDigest instructions reference
sha and sha1
Posted by "Fred Oliver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fred Oliver resolved RIVER-233.
-------------------------------
Resolution: Fixed
> ComputeDigest instructions reference sha and sha1
> -------------------------------------------------
>
> Key: RIVER-233
> URL: https://issues.apache.org/jira/browse/RIVER-233
> Project: River
> Issue Type: Improvement
> Components: com_sun_jini_tool
> Affects Versions: jtsk_2.1
> Reporter: Fred Oliver
> Assignee: Fred Oliver
> Priority: Trivial
> Fix For: AR2
>
>
> Bugtraq ID [6325665|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6325665]
> The example use of the ComputeDigest tool in the class javadoc uses 'sha' as an example algorithm when the default algorithm is later specified to be 'sha1'. My understanding is that sha and sha1 are the same (they certainly produce the same digest). Perhaps it would be better for the example to use a non-sha algorithm (or at least a non-sha1 algorithm since that is the default).
> ----
> Consistenly using "sha1" should be satisfactory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.