You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2026/06/19 20:19:31 UTC
[PR] Make dateTimeConvert scalar function robust to typed time-value input [pinot]
Jackie-Jiang opened a new pull request, #18814:
URL: https://github.com/apache/pinot/pull/18814
## Summary
The `dateTimeConvert` scalar function previously declared its time-value parameter as `String`, forcing every input to be stringified before parsing. This widens the parameter to `Object` and dispatches on the **input** format the same way [DateTimeConversionTransformFunction] does:
- `EPOCH` / `TIMESTAMP` input is read as a `LONG`.
- `SIMPLE_DATE_FORMAT` input is read as a `STRING`.
The input value is coerced to the target type using the same `PinotDataType` conversion as [FunctionInvoker#convertTypes], so numeric columns, numeric strings, and the date-related logical types produced by the `RecordExtractor` contract (`java.sql.Timestamp`, `java.time.LocalDate`, `java.time.LocalTime`) are all accepted for `EPOCH` / `TIMESTAMP` input rather than being forced through a stringify-then-parse round trip.
This also drops a dead `_bucketingTimeZone` field that was only ever assigned, never read.
Added `testDateTimeConvertRecordExtractorDateTypes` covering the `TIMESTAMP` / `DATE` / `TIME` logical types from the `RecordExtractor` contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make dateTimeConvert scalar function robust to typed time-value input [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #18814:
URL: https://github.com/apache/pinot/pull/18814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make dateTimeConvert scalar function robust to typed time-value input [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18814:
URL: https://github.com/apache/pinot/pull/18814#issuecomment-4754741135
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18814?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.00%. Comparing base ([`648d285`](https://app.codecov.io/gh/apache/pinot/commit/648d285840da4e3b9922477e67227f0d8944e2e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a33aa`](https://app.codecov.io/gh/apache/pinot/commit/06a33aa6a8ef849f19c260733698866de634cc28?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (648d285) and HEAD (06a33aa). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (648d285) | HEAD (06a33aa) |
>|------|------|------|
>|java-21|5|1|
>|unittests|2|1|
>|temurin|5|1|
>|unittests2|1|0|
>|integration|3|0|
>|integration1|1|0|
>|integration2|1|0|
>|custom-integration1|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18814 +/- ##
============================================
- Coverage 64.80% 57.00% -7.80%
+ Complexity 1319 1 -1318
============================================
Files 3388 2599 -789
Lines 210228 151686 -58542
Branches 32948 24568 -8380
============================================
- Hits 136229 86473 -49756
+ Misses 63028 57886 -5142
+ Partials 10971 7327 -3644
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.00% <100.00%> (-7.80%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.00% <100.00%> (-7.80%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.00% <100.00%> (-7.79%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.00% <100.00%> (+0.02%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18814/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/18814?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org