You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2015/06/13 20:52:50 UTC
svn commit: r1685302 -
/maven/shared/trunk/maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java
Author: rfscholte
Date: Sat Jun 13 18:52:50 2015
New Revision: 1685302
URL: http://svn.apache.org/r1685302
Log:
Remove dependency based constructor. All other Filters are only Artifact based.
Also, a Dependency are part of a MavenProject, which should imply that you can the Artifact as well.
Most important: it'll prevent me from writing dirty code.
Modified:
maven/shared/trunk/maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java
Modified: maven/shared/trunk/maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java?rev=1685302&r1=1685301&r2=1685302&view=diff
==============================================================================
--- maven/shared/trunk/maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java (original)
+++ maven/shared/trunk/maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java Sat Jun 13 18:52:50 2015
@@ -73,29 +73,6 @@ public class ArtifactTransitivityFilter
}
- @SuppressWarnings( "unchecked" )
- public ArtifactTransitivityFilter( Dependency dependency, ArtifactFactory factory, ArtifactRepository local,
- List<ArtifactRepository> remote, MavenProjectBuilder builder )
- throws ProjectBuildingException, InvalidDependencyVersionException
- {
-
- this.factory = factory;
- this.local = local;
- this.remote = remote;
-
- Artifact rootArtifactPom =
- factory.createArtifact( dependency.getGroupId(), dependency.getArtifactId(), dependency.getVersion(), "",
- "pom" );
-
- MavenProject rootArtifactProject = builder.buildFromRepository( rootArtifactPom, remote, local );
-
- // load all the artifacts.
- transitiveArtifacts =
- rootArtifactProject.createArtifacts( this.factory, Artifact.SCOPE_TEST,
- new ScopeArtifactFilter( Artifact.SCOPE_TEST ) );
-
- }
-
public Set<Artifact> filter( Set<Artifact> artifacts )
{