You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/09/27 04:56:01 UTC
[GitHub] [spark] Hisoka-X commented on a diff in pull request #43138: [SPARK-44223][CORE] Remove LevelDB support
Hisoka-X commented on code in PR #43138:
URL: https://github.com/apache/spark/pull/43138#discussion_r1338040731
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -726,12 +726,12 @@ package object config {
private[spark] val SHUFFLE_SERVICE_DB_BACKEND =
ConfigBuilder(Constants.SHUFFLE_SERVICE_DB_BACKEND)
.doc("Specifies a disk-based store used in shuffle service local db. " +
- "LEVELDB or ROCKSDB.")
+ "Only supported ROCKSDB at now.")
.version("3.4.0")
.stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValues(DBBackend.values.map(_.toString).toSet)
- .createWithDefault(DBBackend.LEVELDB.name)
+ .createWithDefault(DBBackend.ROCKSDB.name)
Review Comment:
Got it, let me change to rocksdb as default with another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org