You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/29 20:41:53 UTC
[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #123: [DRAFT] try scala 3
pjfanning opened a new pull request, #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #123: [DRAFT] try scala 3
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568183373
I'm not sure a Scala 3 branch is that useful. I think we should just merge the different PRs to main when they are ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #123: [DRAFT] try scala 3
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568180784
@pjfanning It would be ideal to get every connector ready but yes it shouldn't block us. Thankfully we still have time since connector is down the track of our module dependency tree.
I think similar to pekko-http, there is probably merit in creating a specific Scala 3 branch as it will be easier for multiple people to work with, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #123: initial work on scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568317691
@mdedetrich I created a scala3 branch in the apache project. If you think this is ok as a starting point, could you approve merging this to that branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning closed pull request #123: [DRAFT] try scala 3
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #123: [DRAFT] try scala 3
URL: https://github.com/apache/incubator-pekko-connectors/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning merged pull request #123: initial work on scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #123: [DRAFT] try scala 3
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568193307
> I'm not sure a Scala 3 branch is that useful. I think we should just merge the different PRs to main when they are ready.
I would disagree here because unless Scala 3 works perfectly fine for all integrations we are going to dirty the branch which can cause issues later down the track if have to do modifications to Pekko connectors. iirc This is actually the same reason why the scala 3 support was in a separate branch for both akka-http and pekko-http, its because integrating Scala 3 support for the projects in question was complicated and long winding and due to the large amount of integrations I think this project passes that bar.
For example the immediate problem I have is that while I think merging this is fine (from what I can tell its just doing the obligatory scala source changes just so that Scala 3 compiler can accept it) there are other more complicated changes, i.e. migrating from shapless to its new Scala 3 equivalent. If we have enough of such changes then the argument for creating a Scala 3 branch increases over time because we just end up having a lot of quite non trivial changes just to support Scala 3.
In summary having a scala 3 branch allows for more iterative style development which I think is actually preferable for such a project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #123: initial work on scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568462399
merged to scala3 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #123: [DRAFT] try scala 3
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #123:
URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568177944
@mdedetrich I'm going to pause development on this.
I think you might be looking at some of the problems already.
I think there is some value in not necessarily getting every connector working with scala 3 just yet. Start with the easiest ones and do the others over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org