You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/30 06:07:15 UTC
[GitHub] [solr] limingnihao opened a new pull request, #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly
limingnihao opened a new pull request, #1050:
URL: https://github.com/apache/solr/pull/1050
https://issues.apache.org/jira/browse/SOLR-16439
# Description
Cloud Node does not have Core, the admin UI cannot be displayed properly due to cores.sort
# Solution
Cores are null and an array is assigned
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on pull request #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1050:
URL: https://github.com/apache/solr/pull/1050#issuecomment-1263183067
:warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GE6G362HKFE5B36ME1MDVF38?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] limingnihao commented on a diff in pull request #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly
Posted by GitBox <gi...@apache.org>.
limingnihao commented on code in PR #1050:
URL: https://github.com/apache/solr/pull/1050#discussion_r991753125
##########
solr/webapp/web/js/angular/controllers/cloud.js:
##########
@@ -424,7 +424,7 @@ var nodesSubController = function($scope, Collections, System, Metrics) {
// These are the cores we _expect_ to find on this node according to the CLUSTERSTATUS
var cores = nodes[node]['cores'];
if (! cores) {
- cores = {};
+ cores = [];
Review Comment:
Thanks, I've changed it to do `cores.sort` when "if not empty".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1050:
URL: https://github.com/apache/solr/pull/1050#issuecomment-1274456012
This all makes sense to me... @cpoerschke do you want to merge this one? Or I can.. ;-). I never could duplicate it, but it *seems* good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on PR #1050:
URL: https://github.com/apache/solr/pull/1050#issuecomment-1276044800
> ... @cpoerschke do you want to merge this one? ...
Sure, I'm happy to merge this one. https://lists.apache.org/thread/rlz9f52ctl34b2yq21vbw0nxm2qtgcro to first ask on the dev list w.r.t. inclusion in 9.1.0 which is in feature freeze.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly
Posted by GitBox <gi...@apache.org>.
cpoerschke merged PR #1050:
URL: https://github.com/apache/solr/pull/1050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org