You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Frank Scholten (Created) (JIRA)" <ji...@apache.org> on 2012/03/07 17:34:57 UTC
[jira] [Created] (WHIRR-549) Remove dependency on system SSH keys
in tests
Remove dependency on system SSH keys in tests
---------------------------------------------
Key: WHIRR-549
URL: https://issues.apache.org/jira/browse/WHIRR-549
Project: Whirr
Issue Type: Bug
Components: build
Affects Versions: 0.7.1
Reporter: Frank Scholten
Fix For: 0.8.0
Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Andrei Savu (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu resolved WHIRR-549.
-------------------------------
Resolution: Fixed
Marking as fixed. Thanks Frank for looking into this!
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Andrei Savu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224785#comment-13224785 ]
Andrei Savu commented on WHIRR-549:
-----------------------------------
*Important Note*: Next time please attach the patch to the JIRA before committing for review and also make sure you update CHANGES.txt (I will do it now)
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Frank Scholten (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Scholten reassigned WHIRR-549:
------------------------------------
Assignee: Frank Scholten
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Andrei Savu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224528#comment-13224528 ]
Andrei Savu commented on WHIRR-549:
-----------------------------------
We can use the same approach as in DestroyClusterCommandTest.testAllOptions. Something like this:
{noformat}
Map<String, File> keys = KeyPair.generateTemporaryFiles();
int rc = command.run(null, out, null, Lists.newArrayList(
"--private-key-file", keys.get("private").getAbsolutePath()
));
{noformat}
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Frank Scholten (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224746#comment-13224746 ]
Frank Scholten commented on WHIRR-549:
--------------------------------------
Build is stable again!
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Frank Scholten (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224520#comment-13224520 ]
Frank Scholten commented on WHIRR-549:
--------------------------------------
Some tests call ClusterSpec.withTemporaryKeys() directly like in DestroyClusterCommandTest.testAllOptions()
However in other tests such as DestroyClusterCommandTest.testInsufficientOptions() the ClusterSpec is created by the command itself and we have no direct control over it.
Thoughts?
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-549) Remove dependency on system SSH keys
in tests
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224839#comment-13224839 ]
Tom White commented on WHIRR-549:
---------------------------------
> Build is stable again!
Great. I'm not sure why the test failures weren't failing the build, but I've made a change which I hope will fix this ("Publish testing tools result report").
> Remove dependency on system SSH keys in tests
> ---------------------------------------------
>
> Key: WHIRR-549
> URL: https://issues.apache.org/jira/browse/WHIRR-549
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.7.1
> Reporter: Frank Scholten
> Assignee: Frank Scholten
> Fix For: 0.8.0
>
>
> Some tests rely on system SSH keys. This currently causes failing builds on Jenkins. See https://builds.apache.org/view/S-Z/view/Whirr/job/Whirr-Ubuntu/311/org.apache.whirr$whirr-cli/testReport/org.apache.whirr.cli.command/DestroyClusterCommandTest/testInsufficientOptions/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira