You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/21 21:24:11 UTC

[GitHub] [airflow] Udit107710 commented on pull request #9358: Tests for AWS Athena

Udit107710 commented on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-647183587


   > 
   > 
   > This would run the tests against an actual Athena instance, which isn't what we want in our unit tests.
   > 
   > Please look at https://github.com/spulec/moto (already used in other tests, for instance S3) and which supports Athena since 1.3.14 (which are are using). moto as of the latest release may not provide _enough_ mocking, so you may have to use just normal unittest.mock to ensure that no network requests are made in this unit test.
   
   10 days ago, support for various functions in Athena, being used by Airflow has been added to moto. I would recommend to bump moto from 1.3.14 to 1.3.15(latest release). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org