You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Ivan Andika (Jira)" <ji...@apache.org> on 2024/01/25 04:04:00 UTC
[jira] [Comment Edited] (HDDS-10181) Remove duplicate ACL protobuf definitions in interface-storage
[ https://issues.apache.org/jira/browse/HDDS-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810662#comment-17810662 ]
Ivan Andika edited comment on HDDS-10181 at 1/25/24 4:03 AM:
-------------------------------------------------------------
The duplicate ACL protobuf is intended due to as part of HDDS-4242 which separates the storage-protocol and client-protocol proto definitions.
Resolving this as "won't do".
was (Author: JIRAUSER298977):
The duplicate ACL protobuf is intended due to as part of HDDS-4242 which separates the storage-protocol and client-protocol.
Resolving this as "won't do".
> Remove duplicate ACL protobuf definitions in interface-storage
> --------------------------------------------------------------
>
> Key: HDDS-10181
> URL: https://issues.apache.org/jira/browse/HDDS-10181
> Project: Apache Ozone
> Issue Type: Improvement
> Components: OM
> Affects Versions: 1.4.0
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Minor
> Labels: pull-request-available
>
> It's observed that the serialization (toProtobuf) and deserialization (fromProtobuf) of OmPrefixInfo uses OzoneAclStorageUtil, whereas OmKeyInfo, OmBucketInfo, OmVolumeArgs uses OzoneAclUtil. The logic for both classes looks the same.
> There are also duplicate proto definitions for OzoneAclInfo in OmStorageProtocol.proto and OmClientProtocol.proto.
> We need to remove the duplication to prevent any divergence.
> Note: This seems the separation was done as part of HDDS-4242, under HDDS-4216 which are supposed to separate RPC and storage proto files for compatibility reasons by introducing interface-storage package. But it seems only PrefixInfo and UserVolumeInfo have been done for this. If these changes are intended, this can be closed and we can focus on separating the remaining protos instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org