You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bruno Borges (JIRA)" <ji...@apache.org> on 2007/11/15 19:05:45 UTC

[jira] Created: (WICKET-1163) Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId

Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId
----------------------------------------------------------------

                 Key: WICKET-1163
                 URL: https://issues.apache.org/jira/browse/WICKET-1163
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.0-rc1
            Reporter: Bruno Borges
             Fix For: 1.3.0-rc2


When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.

This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);

Outputing markup's id but making it invisible is not useful for nothing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1163) Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId

Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543196 ] 

Gwyn Evans commented on WICKET-1163:
------------------------------------

Also note that setOutputMarkupPlaceholderTag(true) will call setOutputMarkupId(true) for you, so the code only needs to be 
  component.setVisible(false).setOutputMarkupPlaceholderTag(true); 


> Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId
> ----------------------------------------------------------------
>
>                 Key: WICKET-1163
>                 URL: https://issues.apache.org/jira/browse/WICKET-1163
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Bruno Borges
>             Fix For: 1.3.0-rc2
>
>
> When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.
> This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
> component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);
> Outputing markup's id but making it invisible is not useful for anything.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1163) Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1163:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-rc2)

> Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId
> ----------------------------------------------------------------
>
>                 Key: WICKET-1163
>                 URL: https://issues.apache.org/jira/browse/WICKET-1163
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Bruno Borges
>
> When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.
> This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
> component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);
> Outputing markup's id but making it invisible is not useful for anything.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1163) Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1163.
-----------------------------------

    Resolution: Won't Fix

No this won't happen, the conclusion was back then that you have to choose if you want to have a place holder or not.
 That's up to you and some don't want this to be the default

Else the 2 separate methods don't make any sense. Then setOutputMarkupID should already just do that. But we have 2 separate because of some concerns.

> Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId
> ----------------------------------------------------------------
>
>                 Key: WICKET-1163
>                 URL: https://issues.apache.org/jira/browse/WICKET-1163
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Bruno Borges
>             Fix For: 1.3.0-rc2
>
>
> When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.
> This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
> component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);
> Outputing markup's id but making it invisible is not useful for anything.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1163) Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId

Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Borges updated WICKET-1163:
---------------------------------

    Description: 
When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.

This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);

Outputing markup's id but making it invisible is not useful for anything.

  was:
When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.

This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);

Outputing markup's id but making it invisible is not useful for nothing.


> Turn OutputMarkupPlaceholderTag on when invisible+outputMarkupId
> ----------------------------------------------------------------
>
>                 Key: WICKET-1163
>                 URL: https://issues.apache.org/jira/browse/WICKET-1163
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Bruno Borges
>             Fix For: 1.3.0-rc2
>
>
> When a component is made invisible but setOutputMarkupId(true) was called, setOutputMarkupPlaceholderTag should be turned on automatically.
> This must be done for every component that must be displayed only if user clicks in some AjaxFallbackLink:
> component.setVisible(false).setOutputMarkupId(true).setOutputMarkupPlaceholderTag(true);
> Outputing markup's id but making it invisible is not useful for anything.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.