You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/07/16 14:04:25 UTC

[GitHub] [fineract] eBouvard opened a new pull request #1749: Block transfer between different currencies (FINERACT-1355)

eBouvard opened a new pull request #1749:
URL: https://github.com/apache/fineract/pull/1749

## Description
See https://issues.apache.org/jira/browse/FINERACT-1355

## Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

- [x] Create/update unit or integration tests for verifying the changes made.

- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-871063663


   /rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1749: FINERACT-1355 Fix : Don't allow transfer between different currencies

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-863650267


   Hi - thanks for the pull request! Looks good to me... but can you squash the commits to a single one please and write the commit message in line with https://github.com/apache/fineract/#pull-requests, I can then merge this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] eBouvard closed pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

eBouvard closed pull request #1749:
URL: https://github.com/apache/fineract/pull/1749


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola merged pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

ptuomola merged pull request #1749:
URL: https://github.com/apache/fineract/pull/1749


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] eBouvard commented on pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

eBouvard commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-881542813


   Hi @ptuomola I fixed the build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] eBouvard commented on pull request #1749: FINERACT-1355 Fix : Don't allow transfer between different currencies

Posted by GitBox <gi...@apache.org>.

eBouvard commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-865776087


   Hi @ptuomola
   Commit squashed and renamed, sorry for the delay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] eBouvard edited a comment on pull request #1749: FINERACT-1355 Fix : Don't allow transfer between different currencies

Posted by GitBox <gi...@apache.org>.

eBouvard edited a comment on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-865776087


   Hi @ptuomola
   Commits squashed and renamed, sorry for the delay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-871907022


   Hi - looks like the build failed - can you retry or check what's wrong?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola removed a comment on pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

ptuomola removed a comment on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-871063663


   /rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-871066083


   /rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] commented on pull request #1749: Block transfer between different currencies (FINERACT-1355)

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #1749:
URL: https://github.com/apache/fineract/pull/1749#issuecomment-899132543


   This pull request seems to be stale.  Are you still planning to work on it?  We will automatically close it in 30 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org