You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/18 10:20:40 UTC

[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree

BenJFan commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r875725742


##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-clickhouse/src/main/scala/org/apache/seatunnel/spark/clickhouse/sink/Table.scala:
##########
@@ -102,4 +105,10 @@ class Table(val name: String, val database: String, val engine: String, val crea
       CheckResult.success()
     }
   }
+
+  def supportReplicatedMergeTree(ddl: String): String = {

Review Comment:
   `supportReplicatedMergeTree` replace to `localizationEngine` will be more clear. Other guys maybe can do more in this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org