[GitHub] spark pull request #18370: [SPARK-9825][yarn] Do not overwrite final Hadoop ...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18370#discussion_r127054436
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -1177,12 +1191,19 @@ private object Client extends Logging {
       // Subdirectory where the user's Spark and Hadoop config files will be placed.
       val LOCALIZED_CONF_DIR = "__spark_conf__"
     
    +  // Subdirectory in the conf directory containing Hadoop config files.
    +  val LOCALIZED_HADOOP_CONF_DIR = "__hadoop_conf__"
    +
       // File containing the conf archive in the AM. See prepareLocalResources().
       val LOCALIZED_CONF_ARCHIVE = LOCALIZED_CONF_DIR + ".zip"
     
       // Name of the file in the conf archive containing Spark configuration.
       val SPARK_CONF_FILE = "__spark_conf__.properties"
     
    +  // Name of the file containing the gateway's Hadoop configuration, to be overlayed on top of the
    +  // cluster's Hadoop config.
    +  val SPARK_HADOOP_CONF_FILE = "__spark_conf__.xml"
    --- End diff --
    
    perhaps call it __spark_hadoop_conf__.xml to clarity


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org