You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/09 01:00:14 UTC

Review Request 61512: Fixed up 3rdparty CMake modules.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61512/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Repository: mesos


Description
-------

This removes `Mesos3rdpartyConfigure.cmake` entirely, as the only
necessary code in it was moved to `PatchCommand.cmake`, which was
consolidated from `libprocess/cmake/macros` to `cmake`.

`External.cmake` was similarly moved.

The `patch_cmd` function was fixed to work on Windows, allowing
`3rdparty/CMakeLists.txt` to be cleaned up further by consolidating the
setting of different patch commands.


Diffs
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
  3rdparty/cmake/External.cmake PRE-CREATION 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10 


Diff: https://reviews.apache.org/r/61512/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 61512: Fixed up 3rdparty CMake modules.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61512/#review184455
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Aug. 8, 2017, 6 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61512/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2017, 6 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes `Mesos3rdpartyConfigure.cmake` entirely, as the only
> necessary code in it was moved to `PatchCommand.cmake`, which was
> consolidated from `libprocess/cmake/macros` to `cmake`.
> 
> `External.cmake` was similarly moved.
> 
> The `patch_cmd` function was fixed to work on Windows, allowing
> `3rdparty/CMakeLists.txt` to be cleaned up further by consolidating the
> setting of different patch commands.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
>   3rdparty/cmake/External.cmake PRE-CREATION 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10 
> 
> 
> Diff: https://reviews.apache.org/r/61512/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>