You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/15 09:01:38 UTC
Review Request 46262: Added a LoggingTest with authentication.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/
-----------------------------------------------------------
Review request for mesos, Adam B and Alexander Rojas.
Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902
Repository: mesos
Description
-------
The test `LoggingTest.ToggleAuthenticationEnabled`
is added in this patch.
Diffs
-----
src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47
Diff: https://reviews.apache.org/r/46262/diff/
Testing
-------
`sudo make check` on OSX.
Thanks,
Greg Mann
Re: Review Request 46262: Added a LoggingTest with authentication.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129309
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 15, 2016, 9:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 9:01 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
>
>
> Diffs
> -----
>
> src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47
>
> Diff: https://reviews.apache.org/r/46262/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46262: Added a LoggingTest with authentication.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review130427
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On April 15, 2016, 3:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 3:01 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
>
>
> Diffs
> -----
>
> src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47
>
> Diff: https://reviews.apache.org/r/46262/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46262: Added a LoggingTest with authentication.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 15, 2016, 12:03 p.m., Alexander Rojas wrote:
> > src/tests/logging_tests.cpp, line 148
> > <https://reviews.apache.org/r/46262/diff/1/?file=1346283#file1346283line148>
> >
> > Too keep it consistent, could you add subtests for wrong credentials and one which succeeds?
Regarding this comment, see my replies in the patches for MetricsTests.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129105
-----------------------------------------------------------
On April 15, 2016, 7:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 7:01 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
>
>
> Diffs
> -----
>
> src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47
>
> Diff: https://reviews.apache.org/r/46262/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46262: Added a LoggingTest with authentication.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129105
-----------------------------------------------------------
src/tests/logging_tests.cpp (line 148)
<https://reviews.apache.org/r/46262/#comment192576>
Too keep it consistent, could you add subtests for wrong credentials and one which succeeds?
- Alexander Rojas
On April 15, 2016, 9:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 9:01 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
>
>
> Diffs
> -----
>
> src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47
>
> Diff: https://reviews.apache.org/r/46262/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46262: Added a LoggingTest with authentication.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129090
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46254, 46255, 46258, 46259, 46260, 46261, 46262]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 15, 2016, 7:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 7:01 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
>
>
> Diffs
> -----
>
> src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47
>
> Diff: https://reviews.apache.org/r/46262/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>