[jira] [Commented] (AIRFLOW-2159) Fix typos in salesforce_hook

["Dan Fowler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382917#comment-16382917 ] 

Dan Fowler commented on AIRFLOW-2159:
-------------------------------------

This PR resolves this ticket: https://github.com/apache/incubator-airflow/pull/3085

> Fix typos in salesforce_hook
> ----------------------------
>
>                 Key: AIRFLOW-2159
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2159
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>            Reporter: Jakob Homan
>            Assignee: Dan Fowler
>            Priority: Major
>
> There are several typos in the saleforce_hook file that would be a good starter task to fix.
> {noformat}
>     - ndjson:
>         JSON array but each element is new-line deliminated
>         instead of comman deliminated like in `json`
> This requires a significant amount of cleanup.
> Pandas doesn't handle output to CSV and json in a uniform way.
> This is especially painful for datetime types.
> Pandas wants to write them as strings in CSV,
> but as milisecond Unix timestamps.{noformat}
> To fix: comman, deliminated, milisecond.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)