You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/02/26 18:41:41 UTC
[GitHub] iilyak opened a new pull request #1944: Integrate emilio
iilyak opened a new pull request #1944: Integrate emilio
URL: https://github.com/apache/couchdb/pull/1944
## Overview
Add `emilio` erlang linter to ensure unified style.
## Testing recommendations
- do a fresh clone and run `./configure` (make sure `bin/emilio` script is created)
- run `./configure` again and make sure it doesn't try to install `emilio` again
- Update any erlang files in any dependency (except files mentioned in `ignore` section of `emilio.config`)
- Run `make emilio` and make sure that:
- produced warnings are only for (± 3) updated lines
- make fails with non 0 exit code
- Run `bin/emilio -c emilio.config src | bin/warnings_in_scope -s 0` to see warnings from `emilio`
- make sure produced warnings are only for updated lines
- Run `bin/emilio -c emilio.config src` and make sure dependencies mentioned in `ignore` section of `emilio.config` are ignored
- test it on windows if you have access to it (I don't have access to windows :-()
## Related Issues or Pull Requests
## Checklist
- [x] Code is written and works correctly;
- [ ] Changes are covered by tests;
- [ ] Documentation reflects the changes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services