You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Dong Lin <li...@gmail.com> on 2014/07/16 23:30:15 UTC
Review Request 23569: Patch for KAFKA-1525
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1525
https://issues.apache.org/jira/browse/KAFKA-1525
Repository: kafka
Description
-------
KAFKA-1525 DumpLogSegments
Diffs
-----
core/src/main/scala/kafka/tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
Diff: https://reviews.apache.org/r/23569/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 23569: Patch for KAFKA-1525
Posted by Dong Lin <li...@gmail.com>.
> On July 22, 2014, 7:59 p.m., Joel Koshy wrote:
> > Ship It!
Since we recently added txControl to message header, I will also include this in the output of DumpLogSements.
- Dong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/#review48416
-----------------------------------------------------------
On July 16, 2014, 9:30 p.m., Dong Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23569/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 9:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1525
> https://issues.apache.org/jira/browse/KAFKA-1525
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1525 DumpLogSegments
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
>
> Diff: https://reviews.apache.org/r/23569/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dong Lin
>
>
Re: Review Request 23569: Patch for KAFKA-1525
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/#review48416
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On July 16, 2014, 9:30 p.m., Dong Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23569/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 9:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1525
> https://issues.apache.org/jira/browse/KAFKA-1525
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1525 DumpLogSegments
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
>
> Diff: https://reviews.apache.org/r/23569/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dong Lin
>
>
Re: Review Request 23569: Patch for KAFKA-1525
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/#review51055
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On Aug. 15, 2014, 6:49 p.m., Dong Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23569/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 6:49 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1525
> https://issues.apache.org/jira/browse/KAFKA-1525
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1525; DumpLogSegments
>
>
> Diffs
> -----
>
> bin/kafka-dump-log.sh PRE-CREATION
> core/src/main/scala/kafka/tools/DumpLogSegments.scala 8e9d47b8d4adc5754ed8861aa04ddd3c6b629e3d
>
> Diff: https://reviews.apache.org/r/23569/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dong Lin
>
>
Re: Review Request 23569: Patch for KAFKA-1525
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 6:49 p.m.)
Review request for kafka.
Bugs: KAFKA-1525
https://issues.apache.org/jira/browse/KAFKA-1525
Repository: kafka
Description (updated)
-------
KAFKA-1525; DumpLogSegments
Diffs (updated)
-----
bin/kafka-dump-log.sh PRE-CREATION
core/src/main/scala/kafka/tools/DumpLogSegments.scala 8e9d47b8d4adc5754ed8861aa04ddd3c6b629e3d
Diff: https://reviews.apache.org/r/23569/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 23569: Patch for KAFKA-1525
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/
-----------------------------------------------------------
(Updated July 22, 2014, 11:50 p.m.)
Review request for kafka.
Bugs: KAFKA-1525
https://issues.apache.org/jira/browse/KAFKA-1525
Repository: kafka
Description
-------
KAFKA-1525 DumpLogSegments
Diffs
-----
core/src/main/scala/kafka/tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
Diff: https://reviews.apache.org/r/23569/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 23569: Patch for KAFKA-1525
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/
-----------------------------------------------------------
(Updated July 22, 2014, 11:48 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1525
Bugs: KAFKA-1522 and KAFKA-1525
https://issues.apache.org/jira/browse/KAFKA-1522
https://issues.apache.org/jira/browse/KAFKA-1525
Repository: kafka
Description (updated)
-------
KAFKA-1525 DumpLogSegments
Diffs (updated)
-----
core/src/main/scala/kafka/tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
Diff: https://reviews.apache.org/r/23569/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 23569: Patch for KAFKA-1522
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23569/
-----------------------------------------------------------
(Updated July 22, 2014, 11:42 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1522
Bugs: KAFKA-1522 and KAFKA-1525
https://issues.apache.org/jira/browse/KAFKA-1522
https://issues.apache.org/jira/browse/KAFKA-1525
Repository: kafka
Description (updated)
-------
KAFKA-1522 Tansactional messaging request/response definitions
Diffs (updated)
-----
core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db
core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION
core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/23569/diff/
Testing
-------
Thanks,
Dong Lin